-
Notifications
You must be signed in to change notification settings - Fork 323
feat: introduce dependency injection framework #4091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Relevant files to review; rest is impl changes. code/packages/ui/src/providers/web-notifications.ts Lines 1 to 115 in 444ace8
code/packages/ui/src/providers/index.ts Lines 1 to 81 in 444ace8
code/apps/frontend/src/providers/frontend-notifications.ts Lines 1 to 48 in 444ace8
code/apps/frontend/src/providers/organization-context.ts Lines 1 to 108 in 444ace8
code/apps/app-frontend/src/providers/app-notifications.ts Lines 1 to 56 in 444ace8
|
CI is broken for app, not sure why. |
Prerequisite of #4080 |
Signed-off-by: IMB11 <[email protected]>
…h/code into cal/dependency-injection
Signed-off-by: IMB11 <[email protected]>
Signed-off-by: IMB11 <[email protected]>
Signed-off-by: Cal H. <[email protected]>
AbstractNotificationManager
class which can be extended upon by the frontend and app-frontend.$notify
and oldaddNotification
composable to the new DI method.inject
/provide
DI to new system.