Replace tabbed mobile menu with dedicated Contents trigger - #167
Open
williamw wants to merge 2 commits into
Open
Replace tabbed mobile menu with dedicated Contents trigger#167williamw wants to merge 2 commits into
williamw wants to merge 2 commits into
Conversation
…tents trigger The mobile flyout previously overloaded the marketing hamburger with a second "Inference Handbook" tab. Split that back out into its own always-visible sub-bar on doc pages instead, so the marketing menu goes back to marketing-only content and the handbook nav gets a dedicated "Contents" trigger with a full-screen overlay. - Revert MarketingHeader/MarketingHeaderHost to marketing-only, removing the tab state, segmented control, and HandbookNavTree usage - Add DocsContentsNav: a sticky sub-bar (static label + Contents button) rendered above DocBreadcrumbs on every doc page, opening a full-screen overlay that reuses HandbookNavTree for the live sidebar tree - Move HandbookNavTree's CSS out of the header's Shadow-DOM-only stylesheet into its own global stylesheet, since it now renders in the regular light DOM - Portal the Contents overlay to document.body so its z-index isn't trapped inside the sub-bar's own sticky stacking context - Break the sub-bar out of the doc container's centered max-width via the standard viewport-relative technique, so it spans full width and aligns with the header's logo/menu button at every breakpoint - Tighten breadcrumb/TOC-dropdown spacing on mobile doc pages to match the sub-bar's own rhythm - Morph the marketing hamburger's lines into an X on open instead of swapping in "menu"/"close" text labels - Add "LLM Inference Handbook" to the Resources nav menu
The sidebar's top-level "Welcome" link had its own distinct treatment
(larger font, bold, bottom hairline, extra margin) left over from when
it was a longer page title ("LLM Inference Handbook"). Now that it's a
short link, that treatment read as an unintentional visual outlier
instead of part of the sidebar tree.
- Removes the hairline border, oversized font, and extra margin on
desktop so "Welcome" sits flush with the rest of the sidebar
- Matches its font-weight to the bold top-level category labels
(Foundations, Planning your deployment, etc.)
- Restyles the mobile Contents overlay's equivalent link to match its
category headers' uppercase/bold treatment and spacing exactly
serenackuo
approved these changes
Jul 8, 2026
scottamain
reviewed
Jul 8, 2026
scottamain
left a comment
scottamain
left a comment
Collaborator
There was a problem hiding this comment.
I’d prefer to follow the pattern used by the current Bento handbook site, https://bentoml.com/llm/. The hamburger defaults to the Handbook menu and has a "Back to main menu" link that then shows the product nav.
scottamain
requested changes
Jul 8, 2026
scottamain
left a comment
scottamain
left a comment
Collaborator
There was a problem hiding this comment.
I’d like to discuss this further before we merge. I’m concerned this is one too many menus in mobile. It creates 3 menus: one for the product nav, one for the docs nav, and one for the page table of contents (for which the new "Contents" menu can be easily confused).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the tabbed mobile handbook navigation added in #158 with a dedicated, always-visible "Contents" trigger on doc pages, so the marketing hamburger menu goes back to marketing-only content.
https://linear.app/modularml/issue/DESN-1629/llm-handbooks-mobile-menu-doesnt-show-sidebar-links