Skip to content

feat!: bump default build tools to vs2022 for Windows MONGOSH-1648 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat!: bump default build tools to vs2022 for Windows MONGOSH-1648 #51

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
12ccb2d
chore: upgrade build tools to vs2022
kmruiz Dec 4, 2023
ca108a2
chore: upgrade evergreen to vs2022
kmruiz Dec 4, 2023
f74d03e
Merge remote-tracking branch 'origin/main' into feature/upgrade-to-vs…
addaleax Nov 1, 2024
031ee6c
fixup!: remove Node.js 14, 16 from test matrix, add 22
addaleax Nov 1, 2024
f4d480d
fixup: v4 toolchain
addaleax Nov 1, 2024
eca486d
fixup: empty commit to see how CI is doing now
addaleax Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ async function compileNode (
// conflicting arguments have been passed manually.
const vcbuildArgs: string[] = [...buildArgs, ...makeArgs, 'projgen'];
if (!vcbuildArgs.includes('debug') && !vcbuildArgs.includes('release')) { vcbuildArgs.push('release'); }
if (!vcbuildArgs.some((arg) => /^vs/.test(arg))) { vcbuildArgs.push('vs2019'); }
if (!vcbuildArgs.some((arg) => /^vs/.test(arg))) { vcbuildArgs.push('vs2022'); }

for (const module of linkedJSModules) {
vcbuildArgs.push('link-module', module);
Expand Down