feat: add inferNamespacesFromPrivileges, default to true COMPASS-9572

[lerouxb]

Toggling the setting off will disable our fallback code that reads databases and collections from privileges then merges those in with the results of listDatabases and listCollections.

Also renaming is_non_existent to inferred_from_privileges (and all other permutations I could find) throughout the codebase so that it is less confusing. This is because we don't know if these exist or not.

I also fixed the text to say that it might not exist. Long story: COMPASS-9641.

[Copilot]

Pull Request Overview

This PR adds a new user preference inferNamespacesFromPrivileges (defaulting to true) that controls whether Compass infers additional namespaces from user privileges. When disabled, it prevents the fallback code that reads databases and collections from privileges and merges them with listDatabases and listCollections results. Additionally, the PR renames is_non_existent to is_ghost_namespace throughout the codebase for clarity.

• Adds new preference inferNamespacesFromPrivileges with default value true
• Renames is_non_existent to is_ghost_namespace across all files and interfaces
• Updates data service methods to respect the new preference setting

Reviewed Changes

Copilot reviewed 30 out of 33 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/instance-model/lib/model.js	Adds shouldFetchNamespacesFromPrivileges property and preference listener
packages/databases-collections/src/collections-plugin-title.tsx	Renames prop from isNonExistent to isGhostNamespace
packages/databases-collections-list/src/namespace-card.tsx	Updates component props and styling references for ghost namespace
packages/databases-collections-list/src/index.spec.tsx	Updates test data to use new property name
packages/databases-collections-list/src/databases.tsx	Updates prop reference in database list component
packages/databases-collections-list/src/collections.tsx	Updates prop reference in collection list component
packages/database-model/lib/model.js	Updates model property and data service call parameters
packages/data-service/src/instance-detail-helper.ts	Updates type definitions for ghost namespace property
packages/data-service/src/data-service.ts	Implements preference-based namespace fetching logic
packages/data-service/src/data-service.spec.ts	Updates test expectations for renamed property
packages/compass-preferences-model/src/preferences-schema.tsx	Defines new preference schema with validation
packages/compass-settings/src/components/settings/general.tsx	Adds preference to general settings UI
packages/compass-app-stores/src/stores/instance-store.ts	Adds preference change listener for database refresh

[lerouxb]

I turned this back into a draft so I can push some more code tomorrow - the events are firing in the wrong order and I'm going to remove them and solve it in a different way.

[lerouxb]

We don't know if these collections exist if the user didn't have access to listDatabases or listCollections. We don't record whether they had access or not and therefore we can't know at this point. (If they DID have access to those commands then we can probably safely say that these don't exist. But right now we don't know that.)

[lerouxb]

(Arguably we could also change the code in dataService to only infer namespaces from privileges if the corresponding listDatabases() or listCollections() call failed due to not having access. That would simplify matters a bit.)

[lerouxb]

I guess inside dataService's listCollections() or listDatabases() calls we can immediately tell if the corresponding call worked or not and then have different booleans for dbs that definitely don't exist and that may or may not exist 🤔

[lerouxb]

I added a follow-up ticket COMPASS-9641.

[mabaasit]

We also need to update this bit in packages/databases-collections-list/src/namespace-card.tsx:318

[lerouxb]

Thanks! Updated.

[lerouxb]

By making these methods we don't have to be concerned about the event handlers in the store catching the event first and then calling refresh before they got updated here.