-
Notifications
You must be signed in to change notification settings - Fork 229
feat(compass-collection): Collection Plugin Experimentation Assignment Integration – CLOUDP-333845 #7165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compass-collection): Collection Plugin Experimentation Assignment Integration – CLOUDP-333845 #7165
Changes from all commits
e0d6e74
57c2bb5
1a32e51
4a75007
29ce148
41957c6
66413a0
a16f2c9
73a6ea8
36817d3
b725084
97a3614
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
export enum TestName { | ||
export enum ExperimentTestName { | ||
earlyJourneyIndexesGuidance = 'EARLY_JOURNEY_INDEXES_GUIDANCE_20250328', | ||
mockDataGenerator = 'MOCK_DATA_GENERATOR_20251001', | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,5 @@ export type { | |
} from './types'; | ||
|
||
export { CompassExperimentationProvider } from './experimentation-provider'; | ||
export { experimentationServiceLocator } from './provider'; | ||
Comment on lines
9
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be exported from the /provider named export, not from the index There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jcobis as I mentioned above, locators and hooks shouldn't be exported from the index export, only from provider, please remove this export There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry I missed this somehow! Removed it here |
||
export { ExperimentTestName } from './growth-experiments'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to check the
clusterState
instead of theclusterName
, like in this util function. We probably want to only assign if the cluster is inIDLE
state or so.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion! I looked at the
connectable
function, but I think we may actually want to assign regardless of cluster status. Once we're at the collections plugin, we should already be connected anyway.We just want to make sure we're in Atlas.
Seems like other checks for Atlas in the codebase just check for
atlasMetadata
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But maybe we drop the clusterName check to match other patterns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! Up to you then!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't connect to clusters and get to this screen if clusters are not in connectable states, there's no reason to check for specific states here