-
Notifications
You must be signed in to change notification settings - Fork 228
feat(compass-collection): Collection Plugin Experimentation Assignment Integration - remove extra export – CLOUDP-333845 #7175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes a redundant export of experimentationServiceLocator
from the compass-telemetry package index file as part of Collection Plugin Experimentation Assignment Integration work.
- Removes the export of
experimentationServiceLocator
from the main package index
Please fix the issues reported by the |
Seems like the errors are coming from |
@jcobis no, they are not, this is what the failed
The last line clearly states that the issue is in the compass-collection package. If you look higher in the log for any occurences of error messages, you can see this one that is coming from the compass-collection package:
And if the log is a bit too intimidating, you can also just run the check task locally only for this package and see the output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah just saw the check
is failing. Let's fix that
src/stores/collection-tab.spec.ts(9,15): error TS2305: Module '"@mongodb-js/compass-telemetry"' has no exported member 'experimentationServiceLocator'
…into cloudp-333845_export
Remove redundant export