Skip to content

feat(compass-collection): Collection Plugin Experimentation Assignment Integration - remove extra export – CLOUDP-333845 #7175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2025

Conversation

jcobis
Copy link
Collaborator

@jcobis jcobis commented Aug 7, 2025

Remove redundant export

@Copilot Copilot AI review requested due to automatic review settings August 7, 2025 15:49
@jcobis jcobis requested a review from a team as a code owner August 7, 2025 15:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a redundant export of experimentationServiceLocator from the compass-telemetry package index file as part of Collection Plugin Experimentation Assignment Integration work.

  • Removes the export of experimentationServiceLocator from the main package index

@gribnoysup
Copy link
Collaborator

Please fix the issues reported by the check task

@jcobis
Copy link
Collaborator Author

jcobis commented Aug 8, 2025

Please fix the issues reported by the check task

Seems like the errors are coming from compass-import-export package

@gribnoysup
Copy link
Collaborator

@jcobis no, they are not, this is what the failed check task log shows in evergreen if you just click through UI to open a log file:

[2025/08/08 17:44:45.434] No depcheck issue
[2025/08/08 17:44:45.434]  >  Lerna (powered by Nx)   Running target check for 70 projects failed
[2025/08/08 17:44:45.434]    Tasks not run because their dependencies failed or --nx-bail=true:
[2025/08/08 17:44:45.434]    - mongodb-compass:check
[2025/08/08 17:44:45.434]    - @mongodb-js/compass-aggregations:check
[2025/08/08 17:44:45.435]    - @mongodb-js/compass-crud:check
[2025/08/08 17:44:45.435]    - @mongodb-js/compass-explain-plan:check
[2025/08/08 17:44:45.435]    - @mongodb-js/compass-export-to-language:check
[2025/08/08 17:44:45.435]    - @mongodb-js/compass-global-writes:check
[2025/08/08 17:44:45.435]    - @mongodb-js/compass-query-bar:check
[2025/08/08 17:44:45.435]    - @mongodb-js/compass-schema:check
[2025/08/08 17:44:45.435]    - @mongodb-js/compass-schema-validation:check
[2025/08/08 17:44:45.435]    - @mongodb-js/compass-sidebar:check
[2025/08/08 17:44:45.435]    - @mongodb-js/compass-web:check
[2025/08/08 17:44:45.435]    - @mongodb-js/compass-databases-collections:check
[2025/08/08 17:44:45.435]    Failed tasks:
[2025/08/08 17:44:45.435]    - @mongodb-js/compass-collection:check

The last line clearly states that the issue is in the compass-collection package. If you look higher in the log for any occurences of error messages, you can see this one that is coming from the compass-collection package:

[2025/08/08 17:44:17.711] > @mongodb-js/[email protected] typecheck
[2025/08/08 17:44:17.711] > tsc -p tsconfig-lint.json --noEmit
[2025/08/08 17:44:17.711] src/stores/collection-tab.spec.ts(9,15): error TS2305: Module '"@mongodb-js/compass-telemetry"' has no exported member 'experimentationServiceLocator'.
[2025/08/08 17:44:17.711] npm ERR! Lifecycle script `typecheck` failed with error:
[2025/08/08 17:44:17.711] npm ERR! Error: command failed
[2025/08/08 17:44:17.711] npm ERR!   in workspace: @mongodb-js/[email protected]
[2025/08/08 17:44:17.711] npm ERR!   at location: /data/mci/af3432529286c9ebfabc70d691226741/src/packages/compass-collection
[2025/08/08 17:44:17.711] npm ERR! Lifecycle script `check` failed with error:
[2025/08/08 17:44:17.711] npm ERR! Error: command failed
[2025/08/08 17:44:17.711] npm ERR!   in workspace: @mongodb-js/[email protected]
[2025/08/08 17:44:17.711] npm ERR!   at location: /data/mci/af3432529286c9ebfabc70d691226741/src/packages/compass-collection

And if the log is a bit too intimidating, you can also just run the check task locally only for this package and see the output:

npm run check -w packages/compass-collection

> @mongodb-js/[email protected] check
> npm run typecheck && npm run lint && npm run depcheck


> @mongodb-js/[email protected] typecheck
> tsc -p tsconfig-lint.json --noEmit

src/stores/collection-tab.spec.ts:9:15 - error TS2305: Module '"@mongodb-js/compass-telemetry"' has no exported member 'experimentationServiceLocator'.

9 import type { experimentationServiceLocator } from '@mongodb-js/compass-telemetry';
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 1 error in src/stores/collection-tab.spec.ts:9

npm error Lifecycle script `typecheck` failed with error:
npm error code 2
npm error path /Users/sergey.petushkov/Projects/MongoDB/compass2/packages/compass-collection
npm error workspace @mongodb-js/[email protected]
npm error location /Users/sergey.petushkov/Projects/MongoDB/compass2/packages/compass-collection
npm error command failed
npm error command sh -c tsc -p tsconfig-lint.json --noEmit
npm error Lifecycle script `check` failed with error:
npm error code 2
npm error path /Users/sergey.petushkov/Projects/MongoDB/compass2/packages/compass-collection
npm error workspace @mongodb-js/[email protected]
npm error location /Users/sergey.petushkov/Projects/MongoDB/compass2/packages/compass-collection
npm error command failed
npm error command sh -c npm run typecheck && npm run lint && npm run depcheck

@Anemy Anemy self-requested a review August 11, 2025 18:26
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah just saw the check is failing. Let's fix that

 src/stores/collection-tab.spec.ts(9,15): error TS2305: Module '"@mongodb-js/compass-telemetry"' has no exported member 'experimentationServiceLocator'

@jcobis jcobis merged commit f2f82cc into main Aug 11, 2025
56 of 58 checks passed
@jcobis jcobis deleted the cloudp-333845_export branch August 11, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat no release notes Fix or feature not for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants