-
Notifications
You must be signed in to change notification settings - Fork 2
feat/COMPASS-9799 Add support to change field type #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| return ( | ||
| <ObjectTypeContainer> | ||
| {'{}'} | ||
| <span title="object">{'{}'}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, thanks for adding the titles as well!
|
The select closes when I go away (select another field), but is opened after I come back to the field (by clicking on the name) Screen.Recording.2025-10-27.at.19.43.24.mov |
|
Eeek, maybe the LG select isn't made for draggable elements 😅 Screen.Recording.2025-10-27.at.19.51.14.mov |
External Links
Description
In this PR, I added an option to allow changing field types. The list of supported field type will be injected via
EditableDiagramInteractionsProvideralong withonFieldTypeChange.I am using LG Select to show the list of field types. As LG Select does not allow to override the trigger, I am hiding the select button and manually controlling select.
Notes for Reviewers
📸 Screenshots/Screencasts
After
Screen.Recording.2025-10-26.at.19.44.10.mov