Skip to content

Conversation

@mabaasit
Copy link
Contributor

External Links

Description

In this PR, I added an option to allow changing field types. The list of supported field type will be injected via EditableDiagramInteractionsProvider along with onFieldTypeChange.
I am using LG Select to show the list of field types. As LG Select does not allow to override the trigger, I am hiding the select button and manually controlling select.

Notes for Reviewers

📸 Screenshots/Screencasts

After

Screen.Recording.2025-10-26.at.19.44.10.mov

return (
<ObjectTypeContainer>
{'{}'}
<span title="object">{'{}'}</span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, thanks for adding the titles as well!

@paula-stacho
Copy link
Collaborator

paula-stacho commented Oct 27, 2025

The select closes when I go away (select another field), but is opened after I come back to the field (by clicking on the name)

Screen.Recording.2025-10-27.at.19.43.24.mov

@paula-stacho
Copy link
Collaborator

Eeek, maybe the LG select isn't made for draggable elements 😅
One possibility would be to disable dragging when editing, but that means either we bring a state into the library (and override the draggable provided by the customer for this case), or we add this responsibility to the customer which is also not the best solution 🤔

Screen.Recording.2025-10-27.at.19.51.14.mov

@mabaasit mabaasit requested a review from paula-stacho October 29, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants