fix: remove comment #393
Merged
fix: remove comment #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the GitHub Actions workflow for JIRA issue creation by removing an unnecessary comment and adding a conditional check to prevent commenting on failed JIRA issue creation attempts.
- Removes a comment about assigned teams custom field IDs
- Adds conditional execution to the "Add comment" step to only run when JIRA issue creation succeeds
Pull Request Test Coverage Report for Build 16472856155Details
💛 - Coveralls |
fmenezes
reviewed
Jul 23, 2025
| @@ -48,6 +47,7 @@ jobs: | |||
| echo "JIRA action result: ${{ steps.create.outputs.issue-key || 'FAILED' }}" | |||
|
|
|||
| - name: Add comment | |||
| if: steps.create.outputs.issue-key | |||
There was a problem hiding this comment.
this will never be empty
Suggested change
| if: steps.create.outputs.issue-key |
There was a problem hiding this comment.
whats the value here #358 (comment)
There was a problem hiding this comment.
I see the bug, will fix it in https://github.com/mongodb/apix-action
fmenezes
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist