(EAI-1230): Create MDB collection and indexes for Atlas Search benchmark #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 6, 2025 12:24
nlarew
reviewed
Aug 11, 2025
| @@ -0,0 +1,3 @@ | |||
| """MongoDB Datasets - Utilities for importing datasets into MongoDB.""" | |||
|
|
|||
| __version__ = "0.1.0" | |||
There was a problem hiding this comment.
nit - can we add newlines to the end of each file (and ideally track down whatever setting is stripping them out)
nlarew
reviewed
Aug 11, 2025
Comment on lines
7
to
9
| # Structure: packages/datasets/mongodb_datasets/config.py -> ../../../.env | ||
| PROJECT_ROOT = Path(__file__).parent.parent.parent.parent.parent | ||
| ENV_PATH = PROJECT_ROOT / ".env" |
There was a problem hiding this comment.
I assume this works but it's a bit confusing to me:
- The example (i.e. three levels of
..fromconfig.py) would resolve topackages/.envwhich doesn't exist - The actual code calls
parentfive times which doesn't match the example and seems to me like it would be the directory about the rootchatbotrepo.
nlarew
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.mongodb.org/browse/EAI-1230
Changes
Notes