Add tests to cover morphTo with hybrid MongoDB and SQL #2671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
tests-hybrid-morph
branch
from
a007539 to
8c353c1
Compare
GromNaN
commented
Nov 8, 2023
| $photo->save(); | ||
| $photo = $user->photos()->save($photo); | ||
|
|
||
| $this->assertEquals(1, $user->photos->count()); |
There was a problem hiding this comment.
Fails here:
Failed asserting that 0 matches expected 1.
But this error seems to come from Laravel itself: if I replace User with SqlUser and remove the HybridRelations trait from every Sql model, it still fails. I may have an error in the model definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #2669
Add tests for SQL model to MongoDB model morph relation in both directions.
In tests, I rename SQL tables to singular (common practice) to ensure we don't mess with collection name of similar models. It helps when debugging.