[Fix] embed relations serialization

[florianJacques]

Fixed the serialization of embed relations.
These relationships were not necessarily loaded, and could not use their attribute mutators.

Checklist

• Add tests and ensure they pass

[florianJacques]

Hello,
Why Coding Standards / phpcs (pull_request)
Fail ?

[GromNaN]

In order to review the PR properly, could you add some tests that are fixed by the change?

Why Coding Standards / phpcs (pull_request) Fail?

GitHub Action fails to commit the fixes that are found by phpcs.

----------------------------------------------------------------------
FILE                                                  FIXED  REMAINING
----------------------------------------------------------------------
src/Eloquent/EmbedsRelations.php                      2      0
src/Eloquent/DocumentModel.php                        1      0
----------------------------------------------------------------------
A TOTAL OF 3 ERRORS WERE FIXED IN 2 FILES
----------------------------------------------------------------------

[florianJacques]

Yes of course, I will write the tests in the next few days
For CI errors, can I do something?

[GromNaN]

For CI errors, can I do something?

You can run vendor/bin/phpcbf locally to fix the CS issues.

[florianJacques]

Thanks, Done! I'll write the tests when I have some time...

[florianJacques]

Adding test ok

[GromNaN]

It seems to me that this is more of a documentation issue that something we should fix in the code.

As for any relationship, if you want to load the data from an embedded relationship you have to use the Model::$with property or call Builder::with().

[GromNaN]

In order to get the address property correctly casted, you must call with('address'):

Suggested change

	$user = UserWithEmbeds::where('name', 'John Doe')->first();
	$user = UserWithEmbeds::where('name', 'John Doe')->with('addresses')->first();

[GromNaN]

Having this new configuration to "fix" the bugged behavior of the embed relationship seems wrong.

The default $with property can be leveraged:

Suggested change

	protected $withEmbeds = ['addresses'];
	protected $with = ['addresses'];

[GromNaN]

This new method is not used and not tested. It doesn't seems to be part of the fix.

[GromNaN]

Thank you for the contribution and for adding tests.

I verified that using the standard $with property achieves exactly the same result: replacing $withEmbeds with $with in the test model makes the same test pass unchanged. Embedded relations are standard Eloquent relations and load correctly via the built-in eager loading mechanism, without needing a dedicated property.

Closing in favour of documenting the correct use of $with with embedded relations.