fix(toast): make toast icon accessible to screen readers #3057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: af8df03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR improves accessibility for the Toast component by making the variant icon properly accessible to screen readers. Previously, the icon was hidden from assistive technology but provides important visual context about the toast type.
Key Changes
- Replaces
aria-hiddenwith semantic attributes (role="img"andaria-label) on toast variant icons - Adds changeset documentation for the accessibility improvement
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/toast/src/InternalToast/InternalToast.tsx | Updates VariantIcon to use role="img" and aria-label instead of aria-hidden for screen reader accessibility |
| .changeset/warm-groups-fly.md | Documents the accessibility improvement as a patch release |
|
Size Change: +26 B (0%) Total Size: 2.01 MB
ℹ️ View Unchanged
|
shaneeza
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR improves accessibility for the Toast component by making the variant icon properly accessible to screen readers. Previously, the icon was hidden from assistive technology using
aria-hidden, but it provides important visual context about the toast type (success, warning, error, etc.). The change replacesaria-hiddenwith appropriate semantic attributes (role="img"andaria-label) to ensure screen readers can announce the toast variant to users.🎟️ Jira ticket: No associated Jira ticket
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes