[LG-5610] pnpm 10
#3236
Merged
[LG-5610] pnpm 10
#3236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSonOfThomp
requested review from
Copilot and
shaneeza
and removed request for
a team and
Copilot
|
There was a problem hiding this comment.
Pull Request Overview
Upgrade repository tooling to pnpm 10 and introduce optional asdf support for managing Node and pnpm versions.
- Bumps pnpm from 9.15.0 to 10.18.3 across CI workflows and package.json.
- Adds .tool-versions for asdf and a migration script from nvm/corepack to asdf.
- Adds pnpm configuration (packageManager field placement and onlyBuiltDependencies) to optimize install behavior.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/nvm-to-asdf.sh | Adds migration script to transition from nvm/corepack to asdf. |
| package.json | Updates pnpm engine/version and adds onlyBuiltDependencies plus relocates packageManager field. |
| .tool-versions | Introduces asdf version pinning for nodejs and pnpm. |
| .github/workflows/sizeDiff.yml | Updates pnpm version used in size diff workflow. |
| .github/workflows/release.yml | Updates pnpm version across all release workflow jobs. |
| .github/workflows/react17.yml | Updates pnpm version in React 17 compatibility workflow. |
| .github/workflows/pr.yml | Updates pnpm version across PR validation jobs. |
Co-authored-by: Copilot <[email protected]>
|
Size Change: +185 B (+0.01%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
Coverage after merging lg-5610-pnpm-10 into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Updates monorepo tooling to use
pnpm10 (latest)Additionally, adds
.tool-versionsfile forasdfversion manager support.Use of
asdfis optional, but recommended for contributors who will also contribute to other MongoDB codebases that use asdf as a tool manager (Like mms)Migration to
asdfMigration to
asdfis optional, but recommended.To migrate from
nvm/corepacktoasdf, run the scriptscripts/nvm-to-asdf.sh, or manually do the following:corepack(if using)nvmin~/.zshrc~/.zshrcpnpmin ~/.zshrc~/.zshrcasdfasdfin theleafygreen-uidirectoryasdf install;Staying on corepack
If you want to stay on
corepack, you can upgrade to pnpm 10 with