Skip to content

PYTHON-4019 Infinite loop in generic transactional provider due to dup keys #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 17, 2025
Merged

PYTHON-4019 Infinite loop in generic transactional provider due to dup keys #2438

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2095013
PYTHON-4019 Infinite loop in generic transactional provider due to du…
blink1073 Jul 16, 2025
e999ed2
address review
blink1073 Jul 17, 2025
0794992
fix typo
blink1073 Jul 17, 2025
7388986
add linkcheck ignore
blink1073 Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pymongo/asynchronous/client_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,12 @@ async def callback(session, custom_arg, custom_kwarg=None):
``with_transaction`` starts a new transaction and re-executes
the ``callback``.

The ``callback`` MUST NOT silently handle command errors
without allowing such errors to propagate. Command errors may abort the
transaction on the server, and an attempt to commit the transaction will
be rejected with a ``NoSuchTransaction`` error. For more information see
the `transactions specification`_.

When :meth:`~AsyncClientSession.commit_transaction` raises an exception with
the ``"UnknownTransactionCommitResult"`` error label,
``with_transaction`` retries the commit until the result of the
Expand Down Expand Up @@ -689,6 +695,9 @@ async def callback(session, custom_arg, custom_kwarg=None):
:return: The return value of the ``callback``.

.. versionadded:: 3.9

.. _tranactions specification:
https://github.com/mongodb/specifications/blob/master/source/transactions-convenient-api/transactions-convenient-api.md#handling-errors-inside-the-callback
"""
start_time = time.monotonic()
while True:
Expand Down
9 changes: 9 additions & 0 deletions pymongo/synchronous/client_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,6 +659,12 @@ def callback(session, custom_arg, custom_kwarg=None):
``with_transaction`` starts a new transaction and re-executes
the ``callback``.

The ``callback`` MUST NOT silently handle command errors
without allowing such errors to propagate. Command errors may abort the
transaction on the server, and an attempt to commit the transaction will
be rejected with a ``NoSuchTransaction`` error. For more information see
the `transactions specification`_.

When :meth:`~ClientSession.commit_transaction` raises an exception with
the ``"UnknownTransactionCommitResult"`` error label,
``with_transaction`` retries the commit until the result of the
Expand Down Expand Up @@ -688,6 +694,9 @@ def callback(session, custom_arg, custom_kwarg=None):
:return: The return value of the ``callback``.

.. versionadded:: 3.9

.. _tranactions specification:
https://github.com/mongodb/specifications/blob/master/source/transactions-convenient-api/transactions-convenient-api.md#handling-errors-inside-the-callback
"""
start_time = time.monotonic()
while True:
Expand Down
Loading