Skip to content

[Spec Resync] 07-28-2025 #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 31, 2025
Merged

[Spec Resync] 07-28-2025 #2447

merged 6 commits into from
Jul 31, 2025

Conversation

mongodb-drivers-pr-bot[bot]
Copy link
Contributor

The following specs were changed:
-bson_corpus
-collection_management
-connection_logging
-connection_monitoring
-connection_string
-crud
-discovery_and_monitoring
-load_balancer
-sdam_monitoring
-server_selection_logging

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot requested a review from a team as a code owner July 28, 2025 16:01
@NoahStapp NoahStapp self-requested a review July 29, 2025 15:36
@NoahStapp NoahStapp force-pushed the spec-resync-07-28-2025 branch from c78dfc4 to 324bb15 Compare July 30, 2025 15:23
@NoahStapp NoahStapp requested a review from sleepyStick July 30, 2025 17:38
sleepyStick
sleepyStick previously approved these changes Jul 30, 2025
Copy link
Contributor

@sleepyStick sleepyStick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ^-^

@@ -33,7 +33,11 @@ def resync_specs(directory: pathlib.Path, errored: dict[str, str]) -> None:
def apply_patches():
print("Beginning to apply patches") # noqa: T201
subprocess.run(["bash", "./.evergreen/remove-unimplemented-tests.sh"], check=True) # noqa: S603, S607
subprocess.run(["git apply -R --allow-empty ./.evergreen/spec-patch/*"], shell=True, check=True) # noqa: S602, S607
subprocess.run(
["git apply -R --allow-empty --whitespace=fix ./.evergreen/spec-patch/*"], # noqa: S607
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the --whitespace=fix is a nice add!

@NoahStapp NoahStapp requested review from sleepyStick and removed request for sleepyStick July 30, 2025 20:02
Copy link
Contributor

@sleepyStick sleepyStick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@NoahStapp NoahStapp merged commit bfaab82 into master Jul 31, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants