CLOUDP-330556: Auto merge compliance report #4053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
reviewed
Jul 23, 2025
| GH_TOKEN: ${{ steps.app-token.outputs.token }} | ||
| run: | | ||
| gh pr merge "${{ steps.pr.outputs.pull-request-url }}" --auto --squash | ||
| - run: | |
There was a problem hiding this comment.
nit: should we use a library instead? see https://github.com/mongodb/openapi/blob/7c80f06e5a6fd0066e3ba3623452b08fe7cb6c0b/.github/workflows/release-changelog.yml#L116-L118
There was a problem hiding this comment.
I would prefer not to add a third-party dependency. What is the value of it?
There was a problem hiding this comment.
something we dont' need to maintain and should be a bit more reliable - also we already use it in other codebases. no string opinion though
There was a problem hiding this comment.
I would rather avoid the dependency. Especially the security problem we almost had on the verify-changed-files action. I think calling git commands makes it very clear what is going on.
|
Coverage Report 📈
|
blva
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Auto merge compliance report
Jira ticket: CLOUDP-330556
Closes #[issue number]
Checklist
make fmtand formatted my codeFurther comments