Skip to content

Conversation

@igor-karpukhin
Copy link
Collaborator

Summary

Renamed 2nd level Ginkgo labels

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?
  • Have you signed our CLA?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, but I would like to see the CI can run test/e2e/* without issues.

BTW, I see a weird CI issue right now. Does this PR need rebasing on the latest main maybe?

@josvazg
Copy link
Collaborator

josvazg commented Oct 21, 2025

@igor-karpukhin focus prefix filtering is not working for selected e2e or int tests because it is not being used. You need toi pass SKIP_PREFIXES='["focus"]' to actually skip one or more prefixes.

One sample usage is at the e2e2 tests:
https://github.com/mongodb/mongodb-atlas-kubernetes/blob/main/.github/workflows/tests-e2e2.yaml#L76

      - name: Compute Test Matrix
        id: set-matrix
        env:
          PR_LABELS: ${{ steps.get-labels.outputs.result || '["test/e2e2/*"]' }}
          E2E2_LABELS: ${{ env.e2e2_labels }}
          USE_JSON: true
          SKIP_PREFIXES: "[\"focus\"]"
...
        run: |
          # Nightly runs all tests, overriding PR labels as '["test/e2e2/*"]'
          if [ "${GITHUB_REF}" == "refs/heads/main" ] && [ "${EVENT_NAME}" == "schedule" -o "${EVENT_NAME}" == "workflow_dispatch" ];then
            PR_LABELS='["test/e2e2/*"]'
            echo "Nightly runs all tests"
          fi
          echo PR_LABELS="${PR_LABELS}"
          echo E2E2_LABELS="${E2E2_LABELS}"
          make compute-labels
          ./bin/ginkgo-labels > result.json
          echo "E2E2 tests to execute $(cat result.json | jq -c .e2e2)"
          echo "e2e2_matrix=$(cat result.json | jq -c .e2e2)" >> $GITHUB_OUTPUT

@josvazg josvazg merged commit 5d69fdd into main Oct 31, 2025
153 checks passed
@josvazg josvazg deleted the CLOUDP-349099/remove-non-top-level-ginkgo-labels branch October 31, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants