-
Notifications
You must be signed in to change notification settings - Fork 106
CLOUDP-349099: Renamed 2nd level Ginkgo labels #2808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-349099: Renamed 2nd level Ginkgo labels #2808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM, but I would like to see the CI can run test/e2e/* without issues.
BTW, I see a weird CI issue right now. Does this PR need rebasing on the latest main maybe?
6d095a9 to
01d809b
Compare
|
@igor-karpukhin One sample usage is at the e2e2 tests: - name: Compute Test Matrix
id: set-matrix
env:
PR_LABELS: ${{ steps.get-labels.outputs.result || '["test/e2e2/*"]' }}
E2E2_LABELS: ${{ env.e2e2_labels }}
USE_JSON: true
SKIP_PREFIXES: "[\"focus\"]"
...
run: |
# Nightly runs all tests, overriding PR labels as '["test/e2e2/*"]'
if [ "${GITHUB_REF}" == "refs/heads/main" ] && [ "${EVENT_NAME}" == "schedule" -o "${EVENT_NAME}" == "workflow_dispatch" ];then
PR_LABELS='["test/e2e2/*"]'
echo "Nightly runs all tests"
fi
echo PR_LABELS="${PR_LABELS}"
echo E2E2_LABELS="${E2E2_LABELS}"
make compute-labels
./bin/ginkgo-labels > result.json
echo "E2E2 tests to execute $(cat result.json | jq -c .e2e2)"
echo "e2e2_matrix=$(cat result.json | jq -c .e2e2)" >> $GITHUB_OUTPUT |
Summary
Renamed 2nd level Ginkgo labels
Checklist
Reminder (Please remove this when merging)