Skip to content

Use const for helm_chart local chart dir #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2025
Merged

Use const for helm_chart local chart dir #532

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68b47d7
Use const for `helm_chart` local chart dir
viveksinghggits Oct 15, 2025
c43a650
Remove the repalcements from helm.py lib code
viveksinghggits Oct 15, 2025
0833b0a
Merge branch 'master' into use-const-for-helm_chart
MaciejKaras Nov 5, 2025
2e00dfc
Remove circular dependencies
MaciejKaras Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docker/mongodb-kubernetes-tests/kubetester/operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
helm_upgrade,
)
from tests import test_logger
from tests.conftest import LOCAL_HELM_CHART_DIR

OPERATOR_CRDS = (
"mongodb.mongodb.com",
Expand All @@ -43,7 +44,7 @@ def __init__(
namespace: str,
helm_args: Optional[Dict] = None,
helm_options: Optional[List[str]] = None,
helm_chart_path: Optional[str] = "helm_chart",
helm_chart_path: Optional[str] = LOCAL_HELM_CHART_DIR,
name: Optional[str] = "mongodb-kubernetes-operator",
api_client: Optional[client.api_client.ApiClient] = None,
):
Expand Down
3 changes: 2 additions & 1 deletion docker/mongodb-kubernetes-tests/tests/multicluster/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from kubetester.helm import helm_template
from kubetester.multicluster_client import MultiClusterClient
from tests import test_logger
from tests.conftest import LOCAL_HELM_CHART_DIR

logger = test_logger.get_test_logger(__name__)

Expand All @@ -15,7 +16,7 @@ def prepare_multi_cluster_namespaces(
member_cluster_clients: List[MultiClusterClient],
central_cluster_name: str,
skip_central_cluster: bool = True,
helm_chart_path="helm_chart",
helm_chart_path=LOCAL_HELM_CHART_DIR,
):
"""create a new namespace and configures all necessary service accounts there"""

Expand Down
3 changes: 2 additions & 1 deletion docker/mongodb-kubernetes-tests/tests/upgrades/meko_mck_upgrade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from tests.conftest import (
LEGACY_MULTI_CLUSTER_OPERATOR_NAME,
LEGACY_OPERATOR_NAME,
LOCAL_HELM_CHART_DIR,
MULTI_CLUSTER_MEMBER_LIST_CONFIGMAP,
MULTI_CLUSTER_OPERATOR_NAME,
OPERATOR_NAME,
Expand Down Expand Up @@ -142,7 +143,7 @@ def test_upgrade_operator(
operator = Operator(
namespace=namespace,
helm_args=operator_installation_config,
helm_chart_path="helm_chart",
helm_chart_path=LOCAL_HELM_CHART_DIR,
name=OPERATOR_NAME,
)
operator.install()
Expand Down