Skip to content

CLOUDP-349078: custom roles regression tests #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CLOUDP-349078: custom roles regression tests #551

wants to merge 1 commit into from

Conversation

@lsierant
Copy link
Contributor

@lsierant lsierant commented Oct 24, 2025 •
edited
Loading

Summary

This PR adds regression test for custom roles ensuring we will keep backwards compatibility wrt handling empty strings vs omitted fields.

In the subsequent #553 the serialization rules for custom roles will be changed.

Proof of Work

Tests passing.

@lsierant lsierant self-assigned this Oct 24, 2025
@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

⚠️ (this preview might not be accurate if the PR is not rebased on current master branch)

MCK 1.6.0 Release Notes

New Features

  • MongoDBCommunity: Added support to configure custom cluster domain via newly introduced spec.clusterDomain resource field. If spec.clusterDomain is not set, environment variable CLUSTER_DOMAIN is used as cluster domain. If the environment variable CLUSTER_DOMAIN is also not set, operator falls back to cluster.local as default cluster domain.
  • Helm Chart: Introduced two new helm fields operator.podSecurityContext and operator.securityContext that can be used to configure securityContext for Operator deployment through Helm Chart.

Bug Fixes

  • Fixed parsing of the customEnvVars Helm value when values contain = characters.
  • ReplicaSet: Blocked disabling TLS and changing member count simultaneously. These operations must now be applied separately to prevent configuration inconsistencies.

Other Changes

  • kubectl-mongodb plugin: cosign, the signing tool that is used to sign kubectl-mongodb plugin binaries, has been updated to version 3.0.2. With this change, released binaries will be bundled with .bundle files containing both signature and certificate information. For more information on how to verify signatures using new cosign version please refer to -> https://github.com/sigstore/cosign/blob/v3.0.2/doc/cosign_verify-blob.md

@lsierant lsierant added the skip-changelog Use this label in Pull Request to not require new changelog entry file label Oct 24, 2025
@lsierant lsierant mentioned this pull request Oct 25, 2025
Open
@lsierant lsierant force-pushed the lsierant/custom-roles-regression-tests branch 4 times, most recently from 70c14e8 to c150032 Compare October 27, 2025 15:49
@lsierant lsierant marked this pull request as ready for review October 27, 2025 16:01
@lsierant lsierant requested a review from a team as a code owner October 27, 2025 16:01
lsierant
lsierant commented Oct 27, 2025
View reviewed changes
docker/mongodb-kubernetes-tests/tests/authentication/mongodb_custom_roles.py


@fixture(scope="module")
def project_name_prefix(namespace: str) -> str:
Copy link
Contributor Author

@lsierant lsierant Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not necessary - in evg namespaces are already randomized

lsierant
lsierant commented Oct 27, 2025
View reviewed changes
docker/mongodb-kubernetes-tests/tests/authentication/mongodb_custom_roles.py
mongodb_role_with_empty_strings["spec"]["roles"][0]["role"] = "readWrite"
mongodb_role_with_empty_strings.update()

wait_until(lambda: replica_set.get_automation_config_tester().reached_version(rs_version + 1), timeout=120)
Copy link
Contributor Author

@lsierant lsierant Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asserting for versions is not good:

  • it prevents from re-running the test locally
  • it increases risk of flakiness in case any other changes were performed in the meantime

it's better to just wait for the desired state of AC

lsierant
lsierant commented Oct 27, 2025
View reviewed changes
scripts/dev/contexts/root-context
export RELEASE_INITIAL_COMMIT_SHA="9ed5f98fc70c5b3442f633d2393265fb8a2aba0c"
export RELEASE_INITIAL_VERSION="1.3.0"

export CLUSTER_TYPE=kind
Copy link
Contributor Author

@lsierant lsierant Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local run was failing due to undefined errors

@lsierant lsierant force-pushed the lsierant/custom-roles-regression-tests branch from c150032 to 545dc80 Compare October 29, 2025 12:40
@lsierant lsierant force-pushed the lsierant/custom-roles-regression-tests branch from 545dc80 to 71cd46b Compare October 31, 2025 09:28
@lsierant lsierant force-pushed the lsierant/custom-roles-regression-tests branch from 71cd46b to 724fa83 Compare November 3, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m1kola m1kola m1kola approved these changes

@lucian-tosa lucian-tosa lucian-tosa approved these changes

@nammn nammn Awaiting requested review from nammn nammn is a code owner automatically assigned from mongodb/kubernetes-hosted

Assignees

@lsierant lsierant

Labels

skip-changelog Use this label in Pull Request to not require new changelog entry file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lsierant @m1kola @lucian-tosa