-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(NODE-7043, NODE-7217)!: adopt mongodb-client-encryption v7 #4705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
263beb0
wrap FLE errors in MongoCryptErrors
baileympearson 354a899
adopt changes from FLE
baileympearson 00cf2cd
feat(NODE-7043)!: remove crypto callbacks (#4706)
baileympearson fb64abd
use main again
baileympearson cf9baec
adopt mongodb-cient-encryption alpha
baileympearson a70b1f5
use alpha.1
baileympearson 8278fb5
fix
baileympearson a9142ed
remove failing task
baileympearson b904bb1
fix dependency test
baileympearson 9bd578d
fix lint
baileympearson d2dffa2
Merge branch 'main' into NODE-7043-error-wrapper
dariakp 7b59d21
comments
baileympearson 124ccad
fix custom FLE tests
baileympearson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -556,6 +556,9 @@ functions: | |
| export AWS_ACCESS_KEY_ID=${aws_key} | ||
| export AWS_SECRET_ACCESS_KEY=${aws_secret} | ||
|
|
||
| # use Node20 | ||
| export PATH=/opt/devtools/node20/bin:/opt/dev/tools/bin:$PATH | ||
|
|
||
| # Download all the task coverage files. | ||
| # NOTE: All coverage files are too large for V8 to handle the resulting call to | ||
| # JSON.stringify from within nyc, so with stick to Fermiun to include the | ||
|
|
@@ -1994,24 +1997,6 @@ tasks: | |
| - func: install mongodb-client-encryption from source | ||
| - func: assume secrets manager role | ||
| - func: run custom csfle tests | ||
| - name: test-latest-driver-mongodb-client-encryption-6.0.0 | ||
| tags: | ||
| - run-custom-dependency-tests | ||
| commands: | ||
| - command: expansions.update | ||
| type: setup | ||
| params: | ||
| updates: | ||
| - {key: NODE_LTS_VERSION, value: 20.19.0} | ||
| - {key: VERSION, value: '7.0'} | ||
| - {key: TOPOLOGY, value: replica_set} | ||
| - {key: CLIENT_ENCRYPTION, value: 'true'} | ||
| - func: install dependencies | ||
| - func: bootstrap mongo-orchestration | ||
| - func: install package | ||
| vars: | ||
| PACKAGE: [email protected] | ||
| - func: run tests | ||
| - name: test-alpine-fle | ||
| tags: | ||
| - alpine-fle | ||
|
|
@@ -3205,7 +3190,6 @@ buildvariants: | |
| - run-custom-csfle-tests-5.0 | ||
| - run-custom-csfle-tests-rapid | ||
| - run-custom-csfle-tests-latest | ||
| - test-latest-driver-mongodb-client-encryption-6.0.0 | ||
| - name: rhel8-test-gcp-kms | ||
| display_name: GCP KMS Test | ||
| run_on: debian11-small | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -623,27 +623,28 @@ for (const serverVersion of ['5.0', 'rapid', 'latest']) { | |
| }); | ||
| } | ||
|
|
||
| customDependencyTests.push({ | ||
| name: `test-latest-driver-mongodb-client-encryption-6.0.0`, | ||
| tags: ['run-custom-dependency-tests'], | ||
| commands: [ | ||
| updateExpansions({ | ||
| NODE_LTS_VERSION: LOWEST_LTS, | ||
| VERSION: '7.0', | ||
| TOPOLOGY: 'replica_set', | ||
| CLIENT_ENCRYPTION: true | ||
| }), | ||
| { func: 'install dependencies' }, | ||
| { func: 'bootstrap mongo-orchestration' }, | ||
| { | ||
| func: 'install package', | ||
| vars: { | ||
| PACKAGE: '[email protected]' | ||
| } | ||
| }, | ||
| { func: 'run tests' } | ||
| ] | ||
| }); | ||
| // TODO(NODE-6997): update to 7.0.0 after release | ||
| // customDependencyTests.push({ | ||
| // name: `test-latest-driver-mongodb-client-encryption-6.0.0`, | ||
| // tags: ['run-custom-dependency-tests'], | ||
| // commands: [ | ||
| // updateExpansions({ | ||
| // NODE_LTS_VERSION: LOWEST_LTS, | ||
| // VERSION: '7.0', | ||
| // TOPOLOGY: 'replica_set', | ||
| // CLIENT_ENCRYPTION: true | ||
| // }), | ||
| // { func: 'install dependencies' }, | ||
| // { func: 'bootstrap mongo-orchestration' }, | ||
| // { | ||
| // func: 'install package', | ||
| // vars: { | ||
| // PACKAGE: '[email protected]' | ||
| // } | ||
| // }, | ||
| // { func: 'run tests' } | ||
| // ] | ||
| // }); | ||
|
|
||
| const coverageTask = { | ||
| name: 'download and merge coverage'.split(' ').join('-'), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.