-
Couldn't load subscription status.
- Fork 1.8k
fix(NODE-7067): Wrap socket write in a try/catch to ensure errors can be properly wrapped #4759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+61
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
requested changes
Oct 27, 2025
baileympearson
requested changes
Oct 28, 2025
baileympearson
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
As described in https://www.mongodb.com/community/forums/t/mongodb-node-js-driver-vs-aws-lambda-with-provisioned-concurrency/326386, a Node.js writeAfterFIN error can bubble up to the driver.
In NODE-6864, all socket errors were handled to be wrapped in MongoNetworkErrors, however this doesn't appear to be handled.
This change wraps an extra
socket.writecall in a try-catch block, and adds a test for this scenario.Release Highlight
Wrap socket write in a try/catch to ensure errors can be properly wrapped
One
socket.writecall was not correctly wrapped in a try/catch block and network errors could bubble up to the driver. This call is now properly wrapped and will result in a retry.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: description