-
Notifications
You must be signed in to change notification settings - Fork 246
DRIVERS-3064 Add support for the rawData command option #1814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7bf791d
WIP
qingyang-hu 4331667
WIP
qingyang-hu 1f949a6
add yaml files
qingyang-hu 03a3913
fixes
qingyang-hu c4d6dcc
add db aggregate
qingyang-hu 00bdec4
update comments
qingyang-hu d9dd2fd
remove auth requirements for listCollections
qingyang-hu 1c42358
minor change
qingyang-hu a7519b5
Regenerate test files
alcaeus 42b4f9e
compatibility updates
qingyang-hu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
91 changes: 91 additions & 0 deletions
91
source/collection-management/tests/listCollections-rawdata.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
47 changes: 47 additions & 0 deletions
47
source/collection-management/tests/listCollections-rawdata.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
description: "listCollections-rawData" | ||
|
||
schemaVersion: "1.4" | ||
|
||
createEntities: | ||
- client: | ||
id: &client0 client0 | ||
observeEvents: [ commandStartedEvent ] | ||
- database: | ||
id: &database0 database0 | ||
client: *client0 | ||
databaseName: &database0Name database0 | ||
|
||
tests: | ||
- description: "listCollections with rawData option" | ||
runOnRequirements: | ||
- minServerVersion: "8.2.0" | ||
operations: | ||
- name: listCollections | ||
object: *database0 | ||
arguments: | ||
rawData: &rawdata true | ||
expectEvents: | ||
- client: *client0 | ||
events: | ||
- commandStartedEvent: | ||
command: | ||
listCollections: 1 | ||
filter: {} | ||
rawData: *rawdata | ||
- description: "listCollections with rawData option on less than 8.2.0 - ignore argument" | ||
alcaeus marked this conversation as resolved.
Show resolved
Hide resolved
|
||
runOnRequirements: | ||
- maxServerVersion: "8.1.99" | ||
operations: | ||
- name: listCollections | ||
object: *database0 | ||
arguments: | ||
rawData: true | ||
expectEvents: | ||
- client: *client0 | ||
events: | ||
- commandStartedEvent: | ||
command: | ||
listCollections: 1 | ||
filter: {} | ||
rawData: | ||
$$exists: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing for a potential auth failure with PHP, I noticed that this test initially failed because PHP does not send an empty
filter
field in the command. Since we're not testing for any filters, consider removing this line here and in the test below. Alternatively, use$unsetOrMatches
as both are equivalent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in support of the above change. Although our CRUD spec denotes that
find()
takes a requiredfilter
parameter, it says nothing about the outgoing command. And if we consult the find command docs we'll see:I think
$$unsetOrMatches: {}
makes sense in this case.