feat: Add azure attributes in federated database instance resource

[marcabreracast]

Description

• Adds azure to cloud-provider config in federated_database_instance
• Refactored out the cloud_provider_access setup for Azure to acc.cloud_provider_access.go
• There is already a migration test for empty CloudProvider config, so decided not to include an extra migration test.

Link to any related issue(s): CLOUDP-245406

Follow up Work

1. Implement data source and refactor tests to run together with resource.
2. Add documentation

Type of change:

• Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
• New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
• Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
• This change requires a documentation update
• Documentation fix/enhancement

Required Checklist:

• I have signed the MongoDB CLA
• I have read the contributing guides
• I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code
• If changes include deprecations or removals I have added appropriate changelog entries.
• If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

[EspenAlbert]

Investigation notes:

1. cloud_provider_config (parent attribute) is not required in the create operation and is not returned from the API when it is not set. However, the attribute is already marked as Optional+Computed, so keeping it as is to allow no-op when the attribute is removed.
2. aws changing from required to optional to allow azure usage

[marcabreracast]

Addressed in d7da829ac0db2f95da04417bce4fb47c9c5eb1c6

[EspenAlbert]

This information: Changing from required to optional to allow azure usage I would keep only as a PR comment.
Later after this is merged it will be no surprise to find this as optional.

[EspenAlbert]

Looks like we might need to pass the d *schema.ResourceData as before, as the tests are showing that this comment is still valid :/

[EspenAlbert]

We need to add:

          AZURE_ATLAS_APP_ID: ${{ inputs.azure_atlas_app_id }}
          AZURE_SERVICE_PRINCIPAL_ID: ${{ inputs.azure_service_principal_id }}
          AZURE_TENANT_ID: ${{ inputs.azure_tenant_id }}

Here: MONGODB_ATLAS_FEDERATION_SETTINGS_ID: ${{ inputs.mongodb_atlas_federation_settings_id }} so the test can use Azure in CI

[EspenAlbert]

Looks like we need to update the schema of the data sources too. Due to this failing tests:
https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/16174869633/job/45657910272#step:5:91

github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*ResourceData).Set(0xc001192750, {0x2d7628f, 0x15}, {0x2619600, 0xc001a8eff0})
	/home/runner/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/[email protected]/helper/schema/resource_data.go:238 +0x2b2
github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federateddatabaseinstance.dataSourceMongoDBAtlasFederatedDatabaseInstanceRead({0x3197340, 0xc00057e150}, 0xc001192750, {0x2864b80?, 0xc001b6d740?})
	/home/runner/work/terraform-provider-mongodbatlas/terraform-provider-mongodbatlas/internal/service/federateddatabaseinstance/data_source_federated_database_instance.go:336 +0x78d

[EspenAlbert]

All the nested fields starting from cloud_provider_config can be Computed only.
Also, please refactor out the schema for cloud_provider_config and use it in the plural data source too.
Bonus, you can even use it for the resource, with an isDatasource argument

[EspenAlbert]

[nit] Start with uppercase
[nit] A lot of not, maybe it can be written clearer?

For example, Optional-only behavior from the API, but keeping O+C to avoid behavior changes.

[github-actions]

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!