-
Notifications
You must be signed in to change notification settings - Fork 204
feat: Adds new mongodbatlas_cloud_user_team_assignment
resource
#3502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: CLOUDP-320243-dev-2.0.0
Are you sure you want to change the base?
Conversation
Steps: []resource.TestStep{ | ||
{ | ||
Config: cloudUserTeamAssignmentConfig(orgID, userID, teamName), | ||
Check: cloudUserTeamAssignmentAttributeChecks(orgID, userID), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: rename to checks() to keep it short
CheckDestroy: checkDestroy, | ||
Steps: []resource.TestStep{ | ||
{ | ||
Config: cloudUserTeamAssignmentConfig(orgID, userID, teamName), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: rename to configBasic()
@@ -244,6 +244,7 @@ jobs: | |||
autogen: ${{ steps.filter.outputs.autogen == 'true' || env.mustTrigger == 'true' }} | |||
backup: ${{ steps.filter.outputs.backup == 'true' || env.mustTrigger == 'true' }} | |||
control_plane_ip_addresses: ${{ steps.filter.outputs.control_plane_ip_addresses == 'true' || env.mustTrigger == 'true' }} | |||
cloud_user: ${{ steps.filter.outputs.cloud_user == 'true' || env.mustTrigger == 'true' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge my PR today, so this won't be required, you'll just need to add path to the new go files like "'internal/service/clouduserteamassignment/*.go'"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my changes are merged, can you merge changes from the dev branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just done, thank you 👍🏻
"github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/mig" | ||
) | ||
|
||
func TestMigCloudUserTeamAssignmentRS_basic(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add test fro migration journeys to this resource?
Description
Adds new
mongodbatlas_cloud_user_team_assignment
resource.Follow-up PRs:
Datasource
Examples & documentation
Link to any related issue(s): CLOUDP-329984
Type of change:
Required Checklist:
Further comments