feat: Adds new `mongodbatlas_cloud_user_team_assignment` resource #3502

csanx · 2025-07-16T13:56:28Z

Description

Adds new mongodbatlas_cloud_user_team_assignment resource.

Additionally changed the attribute name project_roles_assignments to project_role_assignments in organization and team DS for consistency in naming.

Follow-up PRs:

Datasource
Examples & documentation

Link to any related issue(s): CLOUDP-329984

Type of change:

Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the contributing guides
I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code
If changes include deprecations or removals I have added appropriate changelog entries.
If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

…odel functions

internal/service/clouduserteamassignment/resource_test.go

.github/workflows/acceptance-tests-runner.yml

maastha · 2025-07-16T14:54:46Z

internal/service/clouduserteamassignment/resource_migration_test.go

+	"github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/mig"
+)
+
+func TestMigCloudUserTeamAssignmentRS_basic(t *testing.T) {


should we add test fro migration journeys to this resource?

Since we do not have a clear migration journey at the moment we will do it in a separate pr

…e_assignments in `organization` and `team` DS for consistency in naming.

csanx · 2025-07-21T14:08:12Z

Only Alert Config tests are failing (same as in master)

github-actions · 2025-07-21T14:08:41Z

APIx bot: a message has been sent to Docs Slack channel

Copilot

Pull Request Overview

This PR adds a new mongodbatlas_cloud_user_team_assignment resource to the MongoDB Atlas Terraform provider, enabling management of user-to-team assignments within an organization. The implementation also includes a field name correction for project role assignments across multiple existing resources.

Implements the new cloud user team assignment resource with complete CRUD operations and import functionality
Corrects field naming from project_roles_assignments to project_role_assignments across existing data sources for consistency
Adds comprehensive test coverage including unit tests, acceptance tests, and migration tests

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
internal/service/clouduserteamassignment/*	Complete implementation of the new resource including schema, model conversion, CRUD operations, and tests
internal/service/team/data_source_team_test.go	Updates test to use corrected field name `project_role_assignments`
internal/service/organization/resource_organization_test.go	Updates tests to use corrected field name `project_role_assignments`
internal/common/dsschema/users_schema.go	Corrects schema field name from `project_roles_assignments` to `project_role_assignments`
internal/common/conversion/flatten_expand.go	Updates flattening logic to use corrected field name
internal/provider/provider.go	Registers the new resource with the provider
.github/workflows/acceptance-tests-runner.yml	Adds CI configuration for the new resource tests
.changelog/3502.txt	Documents the new resource addition

internal/service/clouduserteamassignment/resource_schema.go

internal/service/clouduserteamassignment/model.go

ytineo-mongodb

LGTM

internal/common/dsschema/users_schema.go

internal/service/clouduserteamassignment/resource.go

EspenAlbert · 2025-07-22T10:01:35Z

internal/service/clouduserteamassignment/resource_schema.go

+				MarkdownDescription: "Unique 24-hexadecimal digit string that identifies the MongoDB Cloud user.",
+			},
+			"username": schema.StringAttribute{
+				Computed:            true,


I am a bit surprised we are requiring user_id and not username.
I think it is easier for a customer to use username, but maybe I missed the discussion in the technical design?

The API requires user_id attribute. If we put usernames as computed instead of user_id, we would have to implement extra logic to retrieve user_id in order to call the API.
In short, the reason is that we wanted to be aligned with the API.
Additionally, we do support import with username.
Further discussion will be done in today's sync

EspenAlbert · 2025-07-22T10:02:49Z

internal/service/clouduserteamassignment/resource_schema.go

+					},
+				},
+			},
+			"team_ids": schema.SetAttribute{


Why are we including this? Is there no other way for the user to get this info?

EspenAlbert · 2025-07-22T10:03:29Z

internal/service/clouduserteamassignment/resource_schema.go

+				Computed:            true,
+				MarkdownDescription: "String enum that indicates whether the MongoDB Cloud user has a pending invitation to join the organization or they are already active in the organization.",
+			},
+			"roles": schema.SingleNestedAttribute{


Same comment as about the team_ids.
I think the roles for the team would make sense but not all roles?

Again, the reason behind this is that we want to be aligned with what the API returns.
The same for team_ids

I did find roles and team_ids strange within this resource as well, but I see why we have added them. Are both of the attributes also present in cloud_user_org_assignment?

oarbusi

LGTM

AgustinBettati

LGTM, leaving some improvement suggestions

internal/service/clouduserteamassignment/model.go

AgustinBettati · 2025-07-22T22:04:29Z

internal/service/clouduserteamassignment/model.go

+		map[string]attr.Value{
+			"org_roles":                orgRoles,
+			"project_role_assignments": projectRoleAssignmentsSet,
+		},


q: Any reason why we don't use the typed model TFRolesModel?

Just an oversight on my part. I'll update it to use TFRolesModel

AgustinBettati · 2025-07-23T07:33:42Z

internal/service/clouduserteamassignment/resource.go

+func (r *rs) Update(ctx context.Context, req resource.UpdateRequest, resp *resource.UpdateResponse) {
+}


You can provide an error to give users more transparency and guidance, e.g. https://github.com/mongodb/terraform-provider-mongodbatlas/blob/master/internal/service/streamprivatelinkendpoint/resource.go#L133

…ignment` (#3517) * Added DS schema generation and Read operation * Add to provider * Fix * Added tests * Changelog * Modified tests * Removed redundant condition * Removed IsUserID --------- Co-authored-by: Cristina Sánchez Sánchez <[email protected]>

Cristina Sánchez Sánchez added 19 commits July 9, 2025 11:53

Extracted users attribute common schema to dsschema/users_schema.go

91192c2

Added attribute users to team data source

83bef3a

Modified tests

b486498

Modified doc

ac113ed

Added changelog

ae5fe56

Created ressource, schema and models

25b4b63

WIP - Implementing Create method

138c010

Merge branch 'CLOUDP-320243-dev-2.0.0' into CLOUDP-329984

9c29d84

WIP - Added markdown description for attributes in schema and fixed m…

776b107

…odel functions

Fixed variables names

4c518ef

WIP - Implement Read, Update, Delete, Import

0865818

Fixed model attributes names.

6329b76

Minor change

13ad925

Added tests

78464a5

Fix

bb0aaae

Add github

11b6f56

Fix

005b0c8

Merge branch 'CLOUDP-320243-dev-2.0.0' into CLOUDP-329984

dd638e6

Fix

a810a32

github-actions bot added the enhancement label Jul 16, 2025

Cristina Sánchez Sánchez added 2 commits July 16, 2025 15:58

Changelog

10a3c1f

Fix

a54e77c

maastha reviewed Jul 16, 2025

View reviewed changes

Cristina Sánchez Sánchez added 7 commits July 16, 2025 17:30

Fixed function naming

389c42a

Merge branch 'CLOUDP-320243-dev-2.0.0' into CLOUDP-329984

d1dd176

Changed test

7c3c11f

Changed project_role_assignments from List to Set

7ebd8d2

Changed the attribute name project_roles_assignments to project_rol…

3d467d0

…e_assignments in `organization` and `team` DS for consistency in naming.

Merge branch 'CLOUDP-320243-dev-2.0.0' into CLOUDP-329984

73b3bfa

minor changes

eba734d

Cristina Sánchez Sánchez added 3 commits July 21, 2025 11:51

Fix

9519315

Fix

adf5af5

Fix

bfd3817

csanx marked this pull request as ready for review July 21, 2025 14:08

Copilot AI review requested due to automatic review settings July 21, 2025 14:08

csanx requested review from a team as code owners July 21, 2025 14:08

Copilot AI reviewed Jul 21, 2025

View reviewed changes

internal/service/clouduserteamassignment/resource_schema.go Outdated Show resolved Hide resolved

internal/service/clouduserteamassignment/model.go Outdated Show resolved Hide resolved

ytineo-mongodb approved these changes Jul 21, 2025

View reviewed changes

Changed project_role_assignments from List to Set

057f72c

oarbusi reviewed Jul 21, 2025

View reviewed changes

internal/common/dsschema/users_schema.go Show resolved Hide resolved

oarbusi reviewed Jul 21, 2025

View reviewed changes

internal/service/clouduserteamassignment/resource.go Outdated Show resolved Hide resolved

oarbusi reviewed Jul 21, 2025

View reviewed changes

internal/service/clouduserteamassignment/resource.go Outdated Show resolved Hide resolved

EspenAlbert reviewed Jul 22, 2025

View reviewed changes

Removed redundant check

57c73b3

oarbusi approved these changes Jul 22, 2025

View reviewed changes

maastha approved these changes Jul 22, 2025

View reviewed changes

AgustinBettati approved these changes Jul 23, 2025

View reviewed changes

AgustinBettati reviewed Jul 23, 2025

View reviewed changes

Cristina Sánchez Sánchez and others added 2 commits July 23, 2025 10:58

Code improvements

503bbfc

csanx merged commit f166785 into CLOUDP-320243-dev-2.0.0 Jul 28, 2025
75 of 76 checks passed

csanx deleted the CLOUDP-329984 branch July 28, 2025 07:54

		func (r rs) Update(ctx context.Context, req resource.UpdateRequest, resp resource.UpdateResponse) {
		}

feat: Adds new mongodbatlas_cloud_user_team_assignment resource #3502

feat: Adds new mongodbatlas_cloud_user_team_assignment resource #3502

Uh oh!

Conversation

csanx commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change:

Required Checklist:

Further comments

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

csanx commented Jul 21, 2025

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

ytineo-mongodb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

csanx Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oarbusi left a comment

Choose a reason for hiding this comment

Uh oh!

AgustinBettati left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

feat: Adds new `mongodbatlas_cloud_user_team_assignment` resource #3502

feat: Adds new `mongodbatlas_cloud_user_team_assignment` resource #3502

csanx commented Jul 16, 2025 •

edited

Loading

csanx Jul 22, 2025 •

edited

Loading