feat: Add support for MONGODB_ATLAS_PUBLIC_API_KEY and MONGODB_ATLAS_PRIVATE_API_KEY to TF

[andreaangiolillo]

Description

Ticket: CLOUDP-332049

[github-actions]

APIx bot: a message has been sent to Docs Slack channel

[Copilot]

Pull Request Overview

This PR adds support for new environment variables MONGODB_ATLAS_PUBLIC_API_KEY and MONGODB_ATLAS_PRIVATE_API_KEY to the Terraform provider, which are widely used across the MongoDB ecosystem and provide better compatibility with other MongoDB tools.

• Adds the new environment variables to both SDK2 and framework provider implementations
• Updates documentation to recommend the new environment variables over the existing ones
• Includes changelog entry documenting the new feature

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
internal/provider/provider_sdk2.go	Adds new environment variables to the SDK2 provider configuration
internal/provider/provider.go	Adds new environment variables to the framework provider configuration
docs/index.md	Updates documentation to recommend new environment variables and explains compatibility benefits
.changelog/3505.txt	Adds changelog entry for the new environment variables

[oarbusi]

LGTM, only concern I have is that the usages of MONGODB_ATLAS_PUBLIC_KEY across the repo should be changed as well for consistency and to avoid confusion. Could be in this PR or a follow up

[andreaangiolillo]

I don't have a strong opinion but I don't think is needed since MONGODB_ATLAS_PUBLIC_KEY is included to ensure that AtlasCLI and TF use the same env variables. As long you don't use AtlasCLI in your tests you can keep using the current env

[JuliaMongo]

LGTM with a few suggestions.