Directly move functions instead of making methods #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
reviewed
Nov 7, 2019
| { | ||
| if (!function.IsGenerated) continue; | ||
|
|
||
| foreach (var function in from function in context.Functions |
There was a problem hiding this comment.
Overkill usage of query LINQ
tritao
reviewed
Nov 7, 2019
|
|
||
| GenerateClassConstructors(@class); | ||
|
|
||
| foreach (var function in from function in @class.Functions |
tritao
reviewed
Nov 7, 2019
| function.Parameters[0].Name, function.Parameters[1].Name); | ||
| Type retType = function.OriginalReturnType.Type.Desugar(); | ||
| bool regular = retType.IsPrimitiveType(PrimitiveType.Bool); | ||
| WriteLineIndent($@"return {(regular ? string.Empty : "global::System.Convert.ToInt32(")}{ |
There was a problem hiding this comment.
Could use some refactoring, and comments
tritao
reviewed
Nov 7, 2019
| List<Method> methods = HandleMissingOperatorOverloadPair( | ||
| @class, @class.Operators, op1, op2); | ||
| foreach (Method @operator in methods) | ||
| { |
There was a problem hiding this comment.
Add some space between statements in this method
This keeps the original functions instead of ignoring them which helps when rearranging passes - in particular when the pass for symbols is involved. Signed-off-by: Dimitar Dobrev <[email protected]>
ddobrev
force-pushed
the
directly-move-functions
branch
from
e94ae29 to
f6f52ac
Compare
tritao
reviewed
Nov 7, 2019
|
|
||
| foreach (Function function in @class.Functions.Where(f => f.IsGenerated)) | ||
| GenerateFunction(function, @class.Name); | ||
| GenerateClassMethods(@class.Methods); |
tritao
reviewed
Nov 7, 2019
|
|
||
| Write("{0} {1}::{2}(", function.ReturnType, classSig, | ||
| function.Name); | ||
| Write($@"{function.ReturnType} {QualifiedIdentifier(@namespace)}::{ |
There was a problem hiding this comment.
The previous version was easier to read.
ddobrev
force-pushed
the
master
branch
2 times, most recently
from
c8e9f62 to
be54a8b
Compare
ddobrev
force-pushed
the
master
branch
6 times, most recently
from
1610aa5 to
64b1efd
Compare
ddobrev
force-pushed
the
master
branch
2 times, most recently
from
c930b78 to
c38556a
Compare
ddobrev
force-pushed
the
main
branch
7 times, most recently
from
4c1e9b8 to
2fdd082
Compare
ddobrev
force-pushed
the
main
branch
3 times, most recently
from
bcf41e4 to
851ec5e
Compare
ddobrev
force-pushed
the
main
branch
5 times, most recently
from
97610ec to
a2aeaed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the original functions instead of ignoring them which helps when rearranging passes - in particular when the pass for symbols is involved.