This repository was archived by the owner on Sep 4, 2024. It is now read-only.
[Mac] Cache cell width to improve size calculations #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By caching the widths required to render each CompositeCell, the amount of required size calculations is reduced drastically. This also reduces the amount of drawing cycles and improves the overall speed and responsivness of lists/trees a lot.
Therzok
reviewed
Mar 20, 2018
| NSTableColumn tcol = base.AddColumn (col); | ||
| var widths = new List<nfloat> (); | ||
| if (Table.RowCount > 0) | ||
| widths.InsertRange (0, Enumerable.Repeat<nfloat> (-1f, (int)Table.RowCount)); |
There was a problem hiding this comment.
This will do Insert N times instead of doing a block insert. Avoid direct IEnumerables here. Please pass something ICollection derived. (the IEnumerable<T> overload handles checking for ICollection<T>)
There was a problem hiding this comment.
Actually, I think pre-allocating list capacity (new List<nfloat> (table.RowCount) then doing
for (int i = 0; i < Table.RowCount; ++i) widths.Add (-1f) is better
Therzok
reviewed
Mar 20, 2018
| RowHeights.Add (-1); | ||
| foreach (var colWidths in ColumnRowWidths) { | ||
| colWidths.Clear (); | ||
| colWidths.AddRange (Enumerable.Repeat<nfloat> (-1, source.RowCount)); |
There was a problem hiding this comment.
Same as above, AddRange on IEnumerable<T> but not ICollection<T> does not do block copy.
Therzok
approved these changes
Mar 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By caching the widths required to render each CompositeCell, the amount of required size calculations is reduced drastically. This also reduces the amount of drawing cycles and improves the overall speed and responsivness of lists/trees a lot.
Limitation: this adds caching only, but full cell resize is still not supported. A call to
QueueResizewill remeasure the cell and update the height required to render the cell with its current width. For a full resize we'll need to hook the column autosizing into the resizing process.