Fix for missing end effector markers because clear #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davetcoleman
force-pushed
the
no_clear
branch
3 times, most recently
from
737a15f to
25bd32b
Compare
- Do not change the default color to clear - Addresses issues in moveit_grasps - Minor cleanup of EE functions
mlautman
approved these changes
Aug 1, 2019
Contributor
|
I agree with you that |
simonschmeisser
approved these changes
Aug 3, 2019
Contributor
simonschmeisser
left a comment
simonschmeisser
left a comment
There was a problem hiding this comment.
besides the comments about the wording lgtm
| publishEEMarkers(pre_grasp_pose, ee_jmg); | ||
| if (batch_publishing_enabled_) | ||
| trigger(); | ||
|
|
Contributor
There was a problem hiding this comment.
it took me a while to get the difference between publishMarker which would need a trigger in this case and publishMarkers which does not follow the batch_publishing_enabled_ and therefore does not need a separate trigger/publish ever
Member
Author
There was a problem hiding this comment.
yea, its counter intuitive for sure. i'll make a TODO, but i can't address this now...
Member
Author
There was a problem hiding this comment.
Actually i just went ahead and fixed it: PickNikRobotics/rviz_visual_tools#123
Co-Authored-By: Simon Schmeisser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a change in #21