Conversation
|
View this pull request in Lando to land it once approved. |
5adb76f to
1bed162
Compare
894f7b6 to
722e616
Compare
722e616 to
4528dd3
Compare
shtrom
left a comment
shtrom
left a comment
There was a problem hiding this comment.
I think the DEFERRED throttling as it is will block further processing of DEFERRED jobs.
| """Return the next job in the queue from all enabled repositories.""" | ||
| # NOTE: This could include DEFERRED jobs that were deferred due to a | ||
| # closed tree. | ||
| return self.job_type.next_job(repositories=self.enabled_repos).first() |
There was a problem hiding this comment.
It might also be worth adding a note that we want to pick up jobs with closed trees so that we can process non-landing jobs, e.g., handover jobs, without delay, and that the TreeStatus check for will continue deferring the others.
There was a problem hiding this comment.
LGTM. nit: It would be nice to have a test for reprocessing of deferred jobs (: -> https://bugzilla.mozilla.org/show_bug.cgi?id=2021883
Yep. I want to add the test in bug 2021833 before pushing this test, as a regression test. Will have that up today. |
|
This PR is no longer needed. |
2 participants
Uh oh!
There was an error while loading. Please reload this page.