Remove GetFirefoxCallout as it totally breaks the layout and is absolutely not worth it. #13725
+8
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utely not worth it.
|
Another option if we think the download firefox langauge is not explicit enough. Screen.Recording.2025-08-11.at.14.12.39.mov |
I like the option shown in this attached video |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15710
Description
This PR removes the persistent tooltip "you'll need firefox.." positioned above the download/install button on non-firefox browsers.
Context
As noted in the ticket, the tooltip adds significant height to the download button, causing empty space on certain screen widths.
Additionally, the content of the tooltip is not particularly enlightening for the user as the text of the button already says a variation of "download firefox" or "download firefox and install X" dependning on RTAMO availability.
So rather than trying to finese this text into the layout, removing it removes the original problem with much lower effort.
Testing
Standard flow
RTAMO flow
TBD (how to enable RTAMO locally)
Screenshots
Small screen
Medium screen
Large screen