Skip to content

Conversation

bendk
Copy link
Contributor

@bendk bendk commented Sep 24, 2025

Backporting the fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1989840 to the desktop-143 branch (release)

I think we should uplift to release since this is a hard crash and the extension devs are saying that users are reporting issues to them.

For this one, I just used the existing desktop-143 branch, which is what's listed in releases's Cargo.toml.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@bendk bendk requested a review from rvandermeulen September 24, 2025 15:44
@bendk bendk changed the base branch from main to desktop-143 September 24, 2025 15:44
@bendk bendk changed the title Push vtrolywotuyy Backport bug 1989840 - Don't call unwrap() in webext-storage custom types #6971 Sep 24, 2025
@rvandermeulen rvandermeulen merged commit b8d3e4b into mozilla:desktop-143 Sep 24, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants