Repository navigation
Find generated unittests - #10032
Find generated unittests#10032lucia-vargas-a wants to merge 7 commits into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR adds a get_unittests_dir helper so the active_users_aggregates v3/v4 generators write unit tests next to their output directory. Before, tests for an absolute --output-dir landed under a relative tests/tmp/... path in the working directory. CI now packages those tests as a separate generated-unittests artifact for validate-metadata and deploy-changes-to-stage. The PR also moves the default metadata description into a constant. I traced the validate_metadata path change, and it gives the same result as the old parents[3]/parts[-4:] logic for both relative and absolute paths. My only comments are about how the CI step picks which generators to re-run.
…ts_for_ci_validation' into deg-11757_fing_generated_unittests_for_ci_validation
This comment has been minimized.
This comment has been minimized.
mikewilli
left a comment
mikewilli
left a comment
There was a problem hiding this comment.
r+wc
I think this PR should remove those tables from the skip list too.
This comment has been minimized.
This comment has been minimized.
PR to remove them - to merge after this one https://github.com/mozilla/bigquery-etl/pull/10036/changes |
⏺ Add empty core_clients_last_seen test files required for focus_android's tests.
This comment has been minimized.
This comment has been minimized.
Integration report
|
This branch has not been deployed
3 participants
Implements DENG-11757.
This PR:
Tests in this repo are not copied to private-bqetl.
The active_users_aggregates exceptions will be removed in a later PR, after this one is merged.
Reviewer, please follow this checklist