Skip to content

Conversation

bani
Copy link
Contributor

@bani bani commented Aug 18, 2025

Description

This PR includes newer Suggest result types so that they can have their own category in urlbar_events tables

Related Tickets & Documents

Assessment of current Suggest events in this spreadsheet.

Reviewer, please follow this checklist

@dataops-ci-bot

This comment has been minimized.

@bani bani requested a review from a team as a code owner August 26, 2025 00:42
@bani bani force-pushed the suggest-results branch 4 times, most recently from 7ca8889 to 824d8e6 Compare August 26, 2025 00:53
@dataops-ci-bot

This comment has been minimized.

@bani bani force-pushed the suggest-results branch from 3be7e38 to 6537c53 Compare August 27, 2025 17:03
@dataops-ci-bot

This comment has been minimized.

@bani bani force-pushed the suggest-results branch from 6537c53 to 12306dc Compare August 27, 2025 18:03
@dataops-ci-bot

This comment has been minimized.

@bani bani force-pushed the suggest-results branch from 12306dc to b37c27f Compare August 27, 2025 18:38
@dataops-ci-bot

This comment has been minimized.

@dataops-ci-bot

This comment has been minimized.

Comment on lines +74 to +75
WHEN res IN ('merino_polygon')
THEN 'merino_market_opt_in'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust_market_opt_in will be the opt-in for market suggestions

merino_market will be online suggestions once the user has opted in

We'll follow that pattern for other opt-in and online suggestions, e.g., rust_yelp_opt_in and merino_yelp.

THEN 'merino_market_opt_in'
WHEN res IN ('tab_serp')
THEN 'open_tab_to_serp'
WHEN res IN ('merino_sports')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is right for online sports, and just to reiterate the opt-in will be rust_sports_opt_in

THEN 'open_tab_to_serp'
WHEN res IN ('merino_sports')
THEN 'sports'
WHEN res IN ('merino_flights')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here, the opt-in will be rust_flights_opt_in

'restrict_keyword_history',
'restrict_keyword_tabs',
'restrict_keyword_actions',
'merino_market',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to point out merino_market here may need to be removed depending on how you handle market types above, to my comment above.

'restrict_keyword_tabs',
'restrict_keyword_actions',
'merino_market',
'important_dates'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be rust_important_dates

'important_dates'
)
THEN res
WHEN res LIKE('%opt_in')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to point out this may need updating depending on how you handle previous comments

@bani bani force-pushed the suggest-results branch from a87ff0e to fd216cf Compare August 28, 2025 14:32
@dataops-ci-bot
Copy link

Integration report for "revised Suggest product list"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/mozfun/norm/result_type_to_product_name/udf.sql /tmp/workspace/generated-sql/sql/mozfun/norm/result_type_to_product_name/udf.sql
--- /tmp/workspace/main-generated-sql/sql/mozfun/norm/result_type_to_product_name/udf.sql	2025-08-28 14:38:44.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/mozfun/norm/result_type_to_product_name/udf.sql	2025-08-28 14:33:55.000000000 +0000
@@ -8,10 +8,10 @@
     WHEN res IN ('rs_amo', 'rust_amo')
       THEN 'suggest_add_on'
     WHEN res IN ('search_suggest', 'search_history', 'search_suggest_rich')
-      THEN 'default_partner_search_suggestion'
+      THEN res -- previously 'default_partner_search_suggestion'
     WHEN res IN ('search_engine')
       THEN 'search_engine'
-    WHEN res IN ('rust_yelp', 'ml_yelp')
+    WHEN res IN ('rust_yelp', 'ml_yelp', 'merino_yelp')
       THEN 'yelp_suggestion'
     WHEN res IN ('rust_fakespot_amazon', 'rust_fakespot_bestbuy', 'rust_fakespot_walmart')
       THEN 'fakespot_suggest'
@@ -19,7 +19,7 @@
       THEN 'trending_suggestion'
     WHEN res IN ('history')
       THEN 'history'
-    WHEN res IN ('bookmark', 'keyword')
+    WHEN res IN ('bookmark', 'keyword', 'restrict_keyword_bookmarks')
       THEN 'bookmark'
     WHEN res IN ('tab')
       THEN 'open_tab'
@@ -41,7 +41,7 @@
       THEN 'wikipedia_enhanced'
     WHEN res IN ('dynamic_wikipedia', 'merino_wikipedia')
       THEN 'wikipedia_dynamic'
-    WHEN res IN ('weather')
+    WHEN res IN ('weather', 'merino_weather')
       THEN 'weather'
     WHEN res IN (
         'action',
@@ -55,6 +55,52 @@
       THEN 'pocket_collection'
     WHEN res IN ('rs_mdn', 'rust_mdn')
       THEN 'mdn'
+    WHEN res IN ('rust_vpn')
+      THEN 'vpn'
+    WHEN res IN ('remote_tab')
+      THEN 'tabs'
+    WHEN res IN ('calc')
+      THEN 'calculator'
+    WHEN res IN ('tip_onboard', 'tip_redirect', 'tip_persist')
+      THEN 'tip'
+    WHEN res IN ('autofill_about')
+      THEN 'about_autofill'
+    WHEN res IN ('autofill_adaptive')
+      THEN 'adaptive_autofill'
+    WHEN res IN ('unit')
+      THEN 'unit_converter'
+    WHEN res IN ('fxsuggest_data_sharing_opt_in')
+      THEN 'online_suggest_opt_in'
+    WHEN res IN ('merino_polygon')
+      THEN 'merino_market_opt_in'
+    WHEN res IN ('tab_serp')
+      THEN 'open_tab_to_serp'
+    WHEN res IN ('merino_market')
+      THEN 'market'
+    WHEN res IN ('merino_sports')
+      THEN 'sports'
+    WHEN res IN ('merino_flights')
+      THEN 'flights'
+    WHEN res IN ('rust_important_dates')
+      THEN 'important_dates'
+    WHEN res IN (
+        'top_site',
+        'recent_search',
+        'history_serp',
+        'history_semantic',
+        'history_semantic_serp',
+        'url',
+        'tab_to_search',
+        'tab_semantic',
+        'tab_semantic_serp',
+        'clipboard',
+        'restrict_keyword_history',
+        'restrict_keyword_tabs',
+        'restrict_keyword_actions'
+      )
+      THEN res
+    WHEN res LIKE('rust_%_opt_in')
+      THEN SUBSTR(res, 6)
     ELSE 'other'
   END
 );

Link to full diff

@bani bani added this pull request to the merge queue Aug 28, 2025
Merged via the queue into main with commit df8edf0 Aug 28, 2025
22 checks passed
@bani bani deleted the suggest-results branch August 28, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants