-
Notifications
You must be signed in to change notification settings - Fork 116
Updated Suggest types - Aug/2025 #7965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
7ca8889 to
824d8e6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| WHEN res IN ('merino_polygon') | ||
| THEN 'merino_market_opt_in' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rust_market_opt_in will be the opt-in for market suggestions
merino_market will be online suggestions once the user has opted in
We'll follow that pattern for other opt-in and online suggestions, e.g., rust_yelp_opt_in and merino_yelp.
| THEN 'merino_market_opt_in' | ||
| WHEN res IN ('tab_serp') | ||
| THEN 'open_tab_to_serp' | ||
| WHEN res IN ('merino_sports') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is right for online sports, and just to reiterate the opt-in will be rust_sports_opt_in
| THEN 'open_tab_to_serp' | ||
| WHEN res IN ('merino_sports') | ||
| THEN 'sports' | ||
| WHEN res IN ('merino_flights') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly here, the opt-in will be rust_flights_opt_in
| 'restrict_keyword_history', | ||
| 'restrict_keyword_tabs', | ||
| 'restrict_keyword_actions', | ||
| 'merino_market', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to point out merino_market here may need to be removed depending on how you handle market types above, to my comment above.
| 'restrict_keyword_tabs', | ||
| 'restrict_keyword_actions', | ||
| 'merino_market', | ||
| 'important_dates' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be rust_important_dates
| 'important_dates' | ||
| ) | ||
| THEN res | ||
| WHEN res LIKE('%opt_in') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to point out this may need updating depending on how you handle previous comments
Integration report for "revised Suggest product list"
|
Description
This PR includes newer Suggest result types so that they can have their own category in urlbar_events tables
Related Tickets & Documents
Assessment of current Suggest events in this spreadsheet.
Reviewer, please follow this checklist