MNTOR-4981: Apply the chainsaw #6149
Merged
+882
−5,361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codemist
reviewed
Sep 25, 2025
| manually_resolved: boolean; | ||
| broker_status: DataBrokerRemovalStatus; | ||
| data_broker: string; | ||
| source: MoscaryData["ScanResult"]["source"]; |
There was a problem hiding this comment.
Do we need to run the schema change first before this?
There was a problem hiding this comment.
The migration to change the schema is part of this PR (and of the same commit that modifies knex-tables, so that it's easy to find).
rhelmer
requested changes
Sep 29, 2025
| ? adjustedScanData.scan.onerep_scan_status === "in_progress" | ||
| : adjustedScanData.scan?.status === "in_progress") && | ||
| props.scanCount === 1; | ||
| adjustedScanData.scan?.onerep_scan_status === "in_progress"; |
There was a problem hiding this comment.
Do we no longer need props.scanCount === 1?
There was a problem hiding this comment.
Oh wow, very good find! I must have missed the closing bracket for the ternary, and thought the && was part of the : branch. This would've been annoying to debug later. Fixed in c2ee90f.
rhelmer
approved these changes
Sep 29, 2025
Vinnl
force-pushed
the
MNTOR-4981-remove-moscary-references
branch
from
c2ee90f to
ae94ba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-4981