chore(db): sync subscribers types with db schema #6281
+0
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschelonka
force-pushed
the
fix/subscribers-schema
branch
from
5c39747 to
9dcd208
Compare
Vinnl
approved these changes
Nov 19, 2025
Collaborator
Vinnl
left a comment
Vinnl
left a comment
There was a problem hiding this comment.
Looks like I reviewed the code that removed it and didn't catch that the types weren't updated - thanks for catching!
(Maybe we should have a CI job that checks that commits or PRs with migrations also modify knex-tables.d.ts?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove two columns that do not exist anymore (removed by #4399)