Bug 1915775 - Change spacing between "PerfCompare" header and "Home" back button #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed styling of "PerfCompare" header and added a new style for the "Home" button to match Figma design.
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
=======================================
Coverage 95.23% 95.24%
=======================================
Files 98 98
Lines 2751 2755 +4
Branches 544 544
=======================================
+ Hits 2620 2624 +4
Misses 129 129
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kala-moz
requested changes
Oct 1, 2025
| <p>Home</p> | ||
| </Stack> | ||
| </Link> | ||
| <Box className={`${styles.box}`}> |
There was a problem hiding this comment.
This can be className={styles.box} No need for the template literals here since we don't have a string name for the className
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed styling of "PerfCompare" header and added a new style for the "Home" button to match Figma design. Now the spacing between the home button and header is 42px and the spacing between the home button and the comparison card is 26px as in the Figma design.