TOOLS/umpv: add replace argument #16301
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: Windows |
oidro
force-pushed
the
umpv-replace-argument
branch
from
256cb1e to
6cacf59
Compare
kasper93
reviewed
Jul 4, 2025
| files = (os.path.abspath(f) if not is_url(f) else f for f in sys.argv[1:]) | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument( | ||
| "--replace", |
There was a problem hiding this comment.
maybe instead --replace just allow string input with that would be inserted as a flag to insert? Would be more versatile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a
--replaceargument to umpv, and replacessys.argvwithargparse.If
--replaceis supplied, the first file passed to umpv will be sent to the mpv instance with thereplaceflag (all subsequent files will still useappend-play).Unless someone out there has files named
--like-this, scripts using umpv should behave the same as with the previous version.