command: normalize stream-open-filename #16569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dudemanguy
approved these changes
Jul 22, 2025
|
Why shouldn't |
guidocella
changed the title
guidocella
force-pushed
the
stream-open-filename
branch
from
0c56129 to
5ab19f8
Compare
|
Sure either way is fine. |
|
Download the artifacts for this pull request: Windows |
Dudemanguy
reviewed
Jul 24, 2025
Since 38ad1ed path is normalized but stream-open-filename is not, making the docs where it says that they are the same wrong, so normalize stream-open-filename too.
guidocella
force-pushed
the
stream-open-filename
branch
from
5ab19f8 to
9353270
Compare
Dudemanguy
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 38ad1ed path is normalized but stream-open-filename is not, so update the docs where it says that they are the same.
This was not by a user on IRC who was checking if
stream-open-filenameis different frompathto check whether a file is remote.