clipboard-wayland: create data sources in clipboard thread #16571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be used in next commits.
kasper93
reviewed
Jul 23, 2025
Used to signal clipboard backend uninit.
na-na-hi
force-pushed
the
wayland-clipboard-fix-2
branch
from
f9e89ce to
d94bd79
Compare
Currently, it is done in set_data which is called by core. It was never meant to do so and it is not thread safe when data sources are created while a seat is being added/removed. Fix this by passing a message to clipboard thread instead so that it is done in a thread safe way.
Not needed anymore. After data sources are created, the next loop iteration of clipboard_wayland_dispatch_events will immediately start and flush display. This reverts commit c399422.
|
Download the artifacts for this pull request: Windows |
kasper93
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes race when data sources are created while a seat is being added/removed. Also removes an unnecessary flush after the fix.