Skip to content

Also map pl_bit_encoding for hwdec formats #17014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −5
Open

Also map pl_bit_encoding for hwdec formats #17014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions video/mp_image.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,11 +200,25 @@ void mp_image_setfmt(struct mp_image *mpi, int out_fmt)
#else
: PL_ALPHA_UNKNOWN;
#endif
mpi->params.repr.bits = (struct pl_bit_encoding) {
.sample_depth = fmt.comps[0].size,
.color_depth = fmt.comps[0].size - abs(fmt.comps[0].pad),
.bit_shift = MPMAX(0, fmt.comps[0].pad),
};
// Calculate bit encoding from all components (excluding alpha)
struct pl_bit_encoding bits = {0};
const int num_comps = mp_imgfmt_desc_get_num_comps(&fmt);
for (int c = 0; c < MPMIN(num_comps, 3); c++) {
struct pl_bit_encoding cbits = {
.sample_depth = fmt.comps[c].size,
.color_depth = fmt.comps[c].size - abs(fmt.comps[c].pad),
.bit_shift = MPMAX(fmt.comps[c].pad, 0),
};

if (bits.sample_depth && !pl_bit_encoding_equal(&bits, &cbits)) {
// Bit encoding differs between components, cannot handle this
bits = (struct pl_bit_encoding) {0};
break;
}

bits = cbits;
}
mpi->params.repr.bits = bits;
}

static void mp_image_destructor(void *ptr)
Expand Down
Loading