Skip to content

Update scalafmt-core to 3.9.9 #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .git-blame-ignore-revs
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Scala Steward: Reformat with scalafmt 3.9.9
424ec59eb4865feb383ca53b4278dfb8b9b6c36c
2 changes: 1 addition & 1 deletion .scalafmt.conf
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version = 3.9.8
version = 3.9.9
project.layout = StandardConvention
runner.dialect = scala3
maxColumn = 100
Expand Down
182 changes: 106 additions & 76 deletions build.sbt
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
Global / onChangedBuildSource := ReloadOnSourceChanges

// For performance testing, ensure each test run one-by-one
Global / concurrentRestrictions := Seq(
Tags.limit(Tags.Test, 1)
)
Global / concurrentRestrictions := Seq(Tags.limit(Tags.Test, 1))

val AIRFRAME_VERSION = "2025.1.14"

Expand All @@ -15,37 +13,65 @@ ThisBuild / dynverSeparator := "-"
// Publishing metadata
ThisBuild / homepage := Some(url("https://msgpack.org/"))
ThisBuild / licenses := Seq("Apache-2.0" -> url("http://www.apache.org/licenses/LICENSE-2.0.txt"))
ThisBuild / scmInfo := Some(
ScmInfo(
url("https://github.com/msgpack/msgpack-java"),
"scm:[email protected]:msgpack/msgpack-java.git"
ThisBuild / scmInfo :=
Some(
ScmInfo(
url("https://github.com/msgpack/msgpack-java"),
"scm:[email protected]:msgpack/msgpack-java.git"
)
)
)
ThisBuild / developers := List(
Developer(id = "frsyuki", name = "Sadayuki Furuhashi", email = "[email protected]", url = url("https://github.com/frsyuki")),
Developer(id = "muga", name = "Muga Nishizawa", email = "[email protected]", url = url("https://github.com/muga")),
Developer(id = "oza", name = "Tsuyoshi Ozawa", email = "[email protected]", url = url("https://github.com/oza")),
Developer(id = "komamitsu", name = "Mitsunori Komatsu", email = "[email protected]", url = url("https://github.com/komamitsu")),
Developer(id = "xerial", name = "Taro L. Saito", email = "[email protected]", url = url("https://github.com/xerial"))
)

ThisBuild / developers :=
List(
Developer(
id = "frsyuki",
name = "Sadayuki Furuhashi",
email = "[email protected]",
url = url("https://github.com/frsyuki")
),
Developer(
id = "muga",
name = "Muga Nishizawa",
email = "[email protected]",
url = url("https://github.com/muga")
),
Developer(
id = "oza",
name = "Tsuyoshi Ozawa",
email = "[email protected]",
url = url("https://github.com/oza")
),
Developer(
id = "komamitsu",
name = "Mitsunori Komatsu",
email = "[email protected]",
url = url("https://github.com/komamitsu")
),
Developer(
id = "xerial",
name = "Taro L. Saito",
email = "[email protected]",
url = url("https://github.com/xerial")
)
)

val buildSettings = Seq[Setting[_]](
organization := "org.msgpack",
organizationName := "MessagePack",
val buildSettings = Seq[Setting[?]](
organization := "org.msgpack",
organizationName := "MessagePack",
organizationHomepage := Some(url("http://msgpack.org/")),
description := "MessagePack for Java",
scalaVersion := "3.7.1",
Test / logBuffered := false,
description := "MessagePack for Java",
scalaVersion := "3.7.1",
Test / logBuffered := false,
// msgpack-java should be a pure-java library, so remove Scala specific configurations
autoScalaLibrary := false,
crossPaths := false,
autoScalaLibrary := false,
crossPaths := false,
publishMavenStyle := true,
// JVM options for building
scalacOptions ++= Seq("-encoding", "UTF-8", "-deprecation", "-unchecked", "-feature"),
Test / javaOptions ++= Seq("-ea"),
javacOptions ++= Seq("-source", "1.8", "-target", "1.8"),
Compile / compile / javacOptions ++= Seq("-encoding", "UTF-8", "-Xlint:unchecked", "-Xlint:deprecation"),
Compile / compile / javacOptions ++=
Seq("-encoding", "UTF-8", "-Xlint:unchecked", "-Xlint:deprecation"),
// Use lenient validation mode when generating Javadoc (for Java8)
doc / javacOptions := {
val opts = Seq("-source", "1.8")
Expand All @@ -58,17 +84,21 @@ val buildSettings = Seq[Setting[_]](
// Add sonatype repository settings
publishTo := {
val centralSnapshots = "https://central.sonatype.com/repository/maven-snapshots/"
if (isSnapshot.value) Some("central-snapshots" at centralSnapshots)
else localStaging.value
if (isSnapshot.value)
Some("central-snapshots" at centralSnapshots)
else
localStaging.value
},
// Style check config: (sbt-jchekcstyle)
jcheckStyleConfig := "facebook",
// Run jcheckstyle both for main and test codes
Compile / compile := ((Compile / compile) dependsOn (Compile / jcheckStyle)).value,
Test / compile := ((Test / compile) dependsOn (Test / jcheckStyle)).value
Compile / compile :=
((Compile / compile) dependsOn (Compile / jcheckStyle)).value,
Test / compile :=
((Test / compile) dependsOn (Test / jcheckStyle)).value
)

val junitJupiter = "org.junit.jupiter" % "junit-jupiter" % "5.11.4" % "test"
val junitJupiter = "org.junit.jupiter" % "junit-jupiter" % "5.11.4" % "test"
val junitVintage = "org.junit.vintage" % "junit-vintage-engine" % "5.11.4" % "test"

// Project settings
Expand All @@ -77,67 +107,67 @@ lazy val root = Project(id = "msgpack-java", base = file("."))
buildSettings,
// Do not publish the root project
publishArtifact := false,
publish := {},
publishLocal := {}
publish := {},
publishLocal := {}
)
.aggregate(msgpackCore, msgpackJackson)

lazy val msgpackCore = Project(id = "msgpack-core", base = file("msgpack-core"))
.enablePlugins(SbtOsgi)
.settings(
buildSettings,
description := "Core library of the MessagePack for Java",
description := "Core library of the MessagePack for Java",
OsgiKeys.bundleSymbolicName := "org.msgpack.msgpack-core",
OsgiKeys.exportPackage := Seq(
// TODO enumerate used packages automatically
"org.msgpack.core",
"org.msgpack.core.annotations",
"org.msgpack.core.buffer",
"org.msgpack.value",
"org.msgpack.value.impl"
),
OsgiKeys.exportPackage :=
Seq(
// TODO enumerate used packages automatically
"org.msgpack.core",
"org.msgpack.core.annotations",
"org.msgpack.core.buffer",
"org.msgpack.value",
"org.msgpack.value.impl"
),
testFrameworks += new TestFramework("wvlet.airspec.Framework"),
Test / javaOptions ++= Seq(
// --add-opens is not available in JDK8
"-XX:+IgnoreUnrecognizedVMOptions",
"--add-opens=java.base/java.nio=ALL-UNNAMED",
"--add-opens=java.base/sun.nio.ch=ALL-UNNAMED"
),
Test / javaOptions ++=
Seq(
// --add-opens is not available in JDK8
"-XX:+IgnoreUnrecognizedVMOptions",
"--add-opens=java.base/java.nio=ALL-UNNAMED",
"--add-opens=java.base/sun.nio.ch=ALL-UNNAMED"
),
Test / fork := true,
libraryDependencies ++= Seq(
// msgpack-core should have no external dependencies
junitJupiter,
junitVintage,
"org.wvlet.airframe" %% "airframe-json" % AIRFRAME_VERSION % "test",
"org.wvlet.airframe" %% "airspec" % AIRFRAME_VERSION % "test",
// Add property testing support with forAll methods
"org.scalacheck" %% "scalacheck" % "1.18.1" % "test",
// For performance comparison with msgpack v6
"org.msgpack" % "msgpack" % "0.6.12" % "test",
// For integration test with Akka
"com.typesafe.akka" %% "akka-actor" % "2.6.20" % "test",
"org.scala-lang.modules" %% "scala-collection-compat" % "2.13.0" % "test"
)
libraryDependencies ++=
Seq(
// msgpack-core should have no external dependencies
junitJupiter,
junitVintage,
"org.wvlet.airframe" %% "airframe-json" % AIRFRAME_VERSION % "test",
"org.wvlet.airframe" %% "airspec" % AIRFRAME_VERSION % "test",
// Add property testing support with forAll methods
"org.scalacheck" %% "scalacheck" % "1.18.1" % "test",
// For performance comparison with msgpack v6
"org.msgpack" % "msgpack" % "0.6.12" % "test",
// For integration test with Akka
"com.typesafe.akka" %% "akka-actor" % "2.6.20" % "test",
"org.scala-lang.modules" %% "scala-collection-compat" % "2.13.0" % "test"
)
)

lazy val msgpackJackson =
Project(id = "msgpack-jackson", base = file("msgpack-jackson"))
.enablePlugins(SbtOsgi)
.settings(
buildSettings,
name := "jackson-dataformat-msgpack",
description := "Jackson extension that adds support for MessagePack",
OsgiKeys.bundleSymbolicName := "org.msgpack.msgpack-jackson",
OsgiKeys.exportPackage := Seq(
"org.msgpack.jackson",
"org.msgpack.jackson.dataformat"
),
libraryDependencies ++= Seq(
lazy val msgpackJackson = Project(id = "msgpack-jackson", base = file("msgpack-jackson"))
.enablePlugins(SbtOsgi)
.settings(
buildSettings,
name := "jackson-dataformat-msgpack",
description := "Jackson extension that adds support for MessagePack",
OsgiKeys.bundleSymbolicName := "org.msgpack.msgpack-jackson",
OsgiKeys.exportPackage := Seq("org.msgpack.jackson", "org.msgpack.jackson.dataformat"),
libraryDependencies ++=
Seq(
"com.fasterxml.jackson.core" % "jackson-databind" % "2.18.4",
junitJupiter,
junitVintage,
"org.apache.commons" % "commons-math3" % "3.6.1" % "test"
),
testOptions += Tests.Argument(TestFrameworks.JUnit, "-v")
)
.dependsOn(msgpackCore)
testOptions += Tests.Argument(TestFrameworks.JUnit, "-v")
)
.dependsOn(msgpackCore)
8 changes: 4 additions & 4 deletions project/plugins.sbt
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
addSbtPlugin("com.github.sbt" % "sbt-pgp" % "2.3.1")
addSbtPlugin("com.github.sbt" % "sbt-pgp" % "2.3.1")
// TODO: Fixes jacoco error:
// java.lang.NoClassDefFoundError: Could not initialize class org.jacoco.core.internal.flow.ClassProbesAdapter
//addSbtPlugin("com.github.sbt" % "sbt-jacoco" % "3.3.0")
addSbtPlugin("org.xerial.sbt" % "sbt-jcheckstyle" % "0.2.1")
addSbtPlugin("org.xerial.sbt" % "sbt-jcheckstyle" % "0.2.1")
addSbtPlugin("com.github.sbt" % "sbt-osgi" % "0.10.0")
addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.5")
addSbtPlugin("com.github.sbt" % "sbt-dynver" % "5.1.1")
addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.5")
addSbtPlugin("com.github.sbt" % "sbt-dynver" % "5.1.1")

scalacOptions ++= Seq("-deprecation", "-feature")
Loading