Skip to content

Conversation

myryk31415
Copy link

@myryk31415 myryk31415 commented Feb 25, 2025

This adds a devicetree for wiko-chuppito aka Wiko Pulp 4g with following features:

  • uart (not tested)
  • basic usb connection
  • eMMC
  • SD card
  • buttons
  • wifi / bluetooth
  • display
    • touchscreen
    • panel
    • backlight
  • GPU
  • audio
  • camera
  • sensors
    • hall
    • imu
    • magnetometer (need to test orientation)
    • proximity
  • USB OTG
  • charging
  • Vibrator
  • Calls + SMS
  • mobile data

@myryk31415 myryk31415 changed the title Wiko chuppito arm64: dts: qcom: msm8916-wiko-chuppito: add initial devicetree Feb 25, 2025
Copy link
Member

@TravMurav TravMurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more small nits.

Also to note, I'd appreciate if you separate upstreamable and not-yet-upstreamable commits when you work on this. That is, keep addition of display and other nodes that rely on not-yet-upstream drivers as separate commits, and anything that could land upstream squash into a single "Add initial devicetree" commit. (bindings are separate commit that should be first, keep it as is)

I'd also appreciate if you can fill in a short blurb into the bindings/initial dt commit messages, see i.e. this series for an example.

When you're done I'd like to ask you to submit upstreamable part upstream, so I can backport it into our tree and not rebase forever, which would help with maintenance a lot. Of course we will still provide you with preliminary review comments based on what we expect upstream to think while you continue to work in this PR.

@myryk31415
Copy link
Author

What about the WCN3620 module? You do need firmware for that but the drivers are in the kernel right? So it doesn't need an extra commit?

@TravMurav
Copy link
Member

What about the WCN3620 module? You do need firmware for that but the drivers are in the kernel right? So it doesn't need an extra commit?

With a few exceptions, only display panel is non-upstreamable. You can check upstream msm8916 devices for examples of what's "upstreamable" and git history of this repo for examples of something that we didn't/couldn't upstream yet.

@myryk31415 myryk31415 force-pushed the wiko-chuppito branch 2 times, most recently from d6833d0 to c36eab3 Compare March 3, 2025 11:31
@myryk31415 myryk31415 force-pushed the wiko-chuppito branch 2 times, most recently from a0e2ab4 to 2f7234e Compare March 6, 2025 18:37
@myryk31415
Copy link
Author

Oh sorry the incorrect formating and notes I left, I'm gonna clean them up but right now I'm still struggling with the audio

@myryk31415 myryk31415 force-pushed the wiko-chuppito branch 3 times, most recently from 34a8455 to 450da3f Compare March 19, 2025 11:40
@myryk31415 myryk31415 force-pushed the wiko-chuppito branch 2 times, most recently from 171b730 to 5c529e9 Compare June 23, 2025 16:32
@stephan-gh
Copy link
Member

@myryk31415 What is the current state of this? Are you still working on more features for the device? Could you rebase and re-test this on top of the latest msm8916/v6.17-rc6 branch so we can merge it?

@myryk31415
Copy link
Author

I tried to get audio working but rarely spend time on it.
Will try to rebase and test this week.

@myryk31415
Copy link
Author

myryk31415 commented Sep 25, 2025

Can i change the branch I want to merge to? Since its rebased to 6.17

Edit: nvm found it

@myryk31415 myryk31415 changed the base branch from msm8916/6.12.1 to msm8916/6.17-rc6 September 25, 2025 16:28
@myryk31415
Copy link
Author

Also I have a proximity sensor with compatible string "stk,stk3x1x" in the downstream devicetree, I set it to "sensortek,stk3310" for now. Is there a way to find out the exact model withouth the schematics / taking it apart?

Comment on lines +180 to +181
pinctrl-names = "default";
pinctrl-0 = <&pwm_out>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pinctrl-names = "default";
pinctrl-0 = <&pwm_out>;
pinctrl-0 = <&pwm_out>;
pinctrl-names = "default";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants