Skip to content

Conversation

ystade
Copy link
Collaborator

@ystade ystade commented Sep 30, 2025

Description

This PR equips the initialization of the NA FoMaC's Device with a couple of checks that may result in an error if the provided QDMI Device does not satisfy the constraints of the NA Device.

Note: I expect codecov to report unsufficient code coverage. However, to cover all checks in the new initialization routine of the NA device, one would need to implement a separate QDMI device for every validation check. I welcome any suggestions how to solve this issue.

Fixes #1227

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

@ystade ystade added this to the QDMI Support milestone Sep 30, 2025
@ystade ystade self-assigned this Sep 30, 2025
@ystade ystade added enhancement New feature or request c++ Anything related to C++ code NA Anything related to Neutral Atom Quantum Computing QDMI Anything related to QDMI labels Sep 30, 2025
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 76.13636% with 105 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/na/fomac/Device.cpp 70.0% 98 Missing ⚠️
include/mqt-core/na/fomac/Device.hpp 64.7% 6 Missing ⚠️
src/na/device/Generator.cpp 98.9% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code enhancement New feature or request NA Anything related to Neutral Atom Quantum Computing QDMI Anything related to QDMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Check Specialization of QDMI Devices
1 participant