Status codes implementation, addresses #371 #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just spotted this metrics disappears after some time, not sure why this happens yet. |
|
For some reason zero value for status gauge leaded to metric absence, fixed this by avoiding this value. |
|
Thanks for this contribution @hryamzik, overall that seems fine with me. I would feel more at ease to put it behind a flag in a non-default fashion to avoid potential breaking changes though. Would you be happy to introduce it as part of this change? |
|
Can you thing of any scenarios where this behavior update would break things down? I can't imagine any for grafana but not that sure about alert manager rules. So far hiding this behind a flag looks like an extra complexity to me. |
mvisonneau
force-pushed
the
main
branch
3 times, most recently
from
f1d1bc5 to
718e730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.