Skip to content

Refresh the version manifest whenever a version isn't found #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2024
Merged

Refresh the version manifest whenever a version isn't found #19

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfa6c9f
chore: refresh version manifest on fail
cosrnic Jun 15, 2024
d26036d
chore: move manifest check into VersionManager
cosrnic Jun 15, 2024
e66bfa9
fix: make triedToUpdate private
cosrnic Jun 15, 2024
454d31b
fix: move triedToUpdate to the VersionManager struct
cosrnic Jun 15, 2024
2d9ace1
chore: remove debug println's
cosrnic Jun 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions internal/pkg/game/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,9 @@ type (
// Version manager

type VersionManager struct {
cacheFile string
manifestV2 *VersionManifestV2
cacheFile string
manifestV2 *VersionManifestV2
triedToUpdate bool
}

func NewVersionManager(dataDir string) (*VersionManager, error) {
Expand Down Expand Up @@ -117,8 +118,14 @@ func NewVersionManager(dataDir string) (*VersionManager, error) {
func (m *VersionManager) FindVanilla(name string) (*gameModel.VersionInfo, error) {
v, ok := m.manifestV2.Vanilla.Versions[strings.ToLower(name)]
if !ok {
return nil, ErrUnknownVersion
if m.triedToUpdate {
return nil, ErrUnknownVersion
}
m.triedToUpdate = true
m.updateManifest()
return m.FindVanilla(name)
}
m.triedToUpdate = false
return v, nil
}

Expand All @@ -129,8 +136,14 @@ func (m *VersionManager) FindFabric(name, loader string) (*gameModel.VersionInfo

partial, ok := m.manifestV2.Fabric.Versions[strings.ToLower(name)]
if !ok {
return nil, ErrUnknownFabricVersion
if m.triedToUpdate {
return nil, ErrUnknownFabricVersion
}
m.triedToUpdate = true
m.updateManifest()
return m.FindFabric(name, loader)
}
m.triedToUpdate = false

return &gameModel.VersionInfo{
Id: fmt.Sprintf(partial.Id, loader),
Expand Down
Loading