Allow overridden properties that inherit attributes #556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the property in the base class and the property in the subclass would both be returned, causing us to complain about duplicate arguments/options that are actually the same. Closes natemcmaster#555
|
I think this handles all cases of property overriding while still correctly flagging property hiding/similar-looking private properties, but I'm new to C# so I might have missed an edge case! |
|
@natemcmaster Just a friendly reminder! If you'd like, I could also try adding a regression test for this specific case of attribute inheritance so it doesn't get inadvertently removed again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the property in the base class and the property in the subclass would both be returned, causing us to complain about duplicate arguments/options that are actually the same.
Closes #555