feat: new services implementation #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardobittencourt
previously approved these changes
Aug 19, 2020
gabrieldocoutos
force-pushed
the
feat/new-services-implementation
branch
from
684534d to
4cebb6c
Compare
rcandia
approved these changes
Aug 28, 2020
Contributor
rcandia
left a comment
rcandia
left a comment
There was a problem hiding this comment.
Boa padrinho!! Curti bastante a implementação!! 😄
gcdpinho
reviewed
Aug 30, 2020
|
|
||
| import { login as authLogin } from 'services/auth' | ||
| import { setAccessToken, setRefreshToken, clearToken, bootstrapAppData } from 'helpers' | ||
| import { authServices } from 'services/auth' |
Contributor
There was a problem hiding this comment.
Tu não curte importar direto de services?
Como o import já é nominal, não vejo pq não importar do index (pensando também no padrão que já usamos). No entanto, sei que já tivemos algumas discussões inacabadas sobre esse assunto, então resolvi levantar o questionamento aqui para chegarmos em uma conclusão.
De qualquer forma, curti o approach!
eduardobittencourt
approved these changes
Aug 31, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
try a new services implementation
Checklist