feat: remove react-text-mask and add rifm use textfield with mask's #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
devSiso
reviewed
Feb 11, 2022
| }) | ||
| }, | ||
| accept: /\d+/g | ||
| } |
There was a problem hiding this comment.
achei muito pica já ter algumas das máscaras mais comuns, só algumas sugestões.
-
a de currency eu tentaria deixar mais genérico, de uma forma q a gente pudesse escolher moedas diferentes de BRL.
-
adicionar uma máscara de cnpj
-
criar um helper de criação de mascaras númericas, tipo oq o createNumberMask do text-mask-addons faz (https://www.npmjs.com/package/text-mask-addons), será que isso caberia mais à nossa lib de hooks (prometheus)?
powilliam
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Alterar a lib utilizada para implementaçao de máscaras, com a finalidade de integrar de uma melhor forma com a lib de formulário react-hook-form
Does this close any currently open issues?
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.