Scope access-request approvals to services - #185
Conversation
|
Hey @MUFFANUJ, taking this up for review. It's gone stale against |
|
Hey @MUFFANUJ, change of plan on the rebase. I started it and it runs into #197 "remove the notifications", which landed on main after you cut this branch. We decided in the sync to hide the notifications UI for now since it wasn't giving non-admin users anything actionable, so #197 stripped the notification bell and the notification state out of the frontend. Your branch still carries the old notification code, so a straight rebase brings the UI back. That's a product call rather than a merge fix, so I'd rather hand it back than guess for you. Good news is it's small. When you rebase on main the only real conflict is in Heads up too that I marked #187 blocked by this one, since it extends the same entitlement keys. Once this is green I'll pick the review back up. |
Reference Issues or PRs
Closes #156
What does this implement/fix?
Put a
xin the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1or#in markdown).Non-text content
Any other comments?
This changes access-request approval from Keycloak group mutation to Launchpad-owned Redis entitlements scoped by user and service UID. Approved access now expires with a configurable TTL, revoke removes the active grant, and REST/WebSocket access checks only honor exact service grants while preserving approver and target-owner audit data. One follow-up I could think of is to add a renewal flow so users or admins can extend expiresAt before expiry for uninterrupted access.