ci(release): pin Helm to v3.19.0 - #183
Merged
Merged
Conversation
azure/setup-helm's 'version: latest' now resolves to Helm 4, whose chart rendering and packaging differ from the Helm 3 the charts are authored and tested against (build-pr.yml was already pinned; the nebari-app golden tests are Helm 3-rendered). Pin both setup-helm steps in the release workflow so published charts are built with the same Helm the repo tests with, rather than silently shipping Helm 4 output. test-chart.yml is unaffected: it installs Helm via the get-helm-3 script, which already tracks the latest Helm 3. A deliberate Helm 4 migration (regenerate goldens, verify chart build on Helm 4) is the real long-term fix and is out of scope here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
azure/setup-helm@v5withversion: 'latest'now resolves to Helm 4 (v4.2.4 as of writing). The repo's charts and golden tests are authored against Helm 3, and Helm 4 changes chart rendering/packaging output (e.g. trailing newlines in multi-documenthelm template). This already surfaced as a spuriousnebari-appgolden mismatch inbuild-pr.yml, which was pinned tov3.19.0when #180 landed.release.ymlstill had twosetup-helm@v5steps onversion: 'latest', so a release would build and publish charts with Helm 4 output while everything is tested on Helm 3.Change
Pin both
setup-helmsteps inrelease.ymltoversion: v3.19.0, matchingbuild-pr.yml, so published charts are built with the same Helm the repo tests with.test-chart.ymlis not changed: it installs Helm via theget-helm-3script, which already tracks the latest Helm 3, so it is unaffected.Notes
This is the defensive, minimal fix. The real long-term direction is a deliberate Helm 4 migration - regenerate the
nebari-appgoldens under Helm 4, verify the operator chart builds and lints on Helm 4, then move the pins forward (or drop them). That is out of scope here; worth a tracking issue.Test plan
release.ymlparses as valid YAML; bothsetup-helmsteps now readversion: v3.19.0, the goreleaser~> v2version is untouched.